Force new visit after midnight #7014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <nb_visits>1</nb_visits> | ||
| <nb_actions>1</nb_actions> | ||
| <nb_visits>2</nb_visits> | ||
| <nb_actions>2</nb_actions> | ||
| <max_actions>1</max_actions> | ||
| <nb_actions_per_visit>1</nb_actions_per_visit> | ||
| <avg_time_on_site>00:00:00</avg_time_on_site> |
There was a problem hiding this comment.
changes in this test output seems strange to me, maybe something wrong, need to check tomorrow
There was a problem hiding this comment.
It's all good. There is one visit at '2010-01-03 12:22:33', one visit at '2010-01-03 23:55:00' and another one for the next day at '2010-01-04 00:01:00'.
With the old behaviour it was one visit for '2010-01-03 12:22:33', and one visit together for '2010-01-03 23:55:00' and '2010-01-04 00:01:00'. The visit counted for Monday before as the last_action_time was on Monday.
tsteur
added
duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #6217
Added an integration test for this use case. The system test changes seem to be expected but hard to tell!