Changed colours for better accessibility for people with sight difficulties #7011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 14, 2015 14:12
…the widgits on the dashboard to h3 from span without changing what it looked like.
…arker for enough contrast for users with eyesight difficulties.
| @@ -16,7 +16,8 @@ | |||
|
|
|||
| {% if properties.show_search %} | |||
| <span class="dataTableSearchPattern"> | |||
| <input type="text" class="searchInput" length="15" /> | |||
| <label for="widgetSearch_{{ properties.report_id }}" style="display:none;"> {{ 'General_Search'|translate }} for {{ visualization.config.translations.label }}</label> | |||
There was a problem hiding this comment.
you can remove the for word here as it's good enough to have Search Websites or Search Operating Systems rather than Search for Operating Systems
(this way the whole text will be translated in all languages, whereas for wouldnt have been translated)
This was referenced Jan 14, 2015
Closed
|
Thanks for the pull request! |
mattab
changed the title
mattab
added
the
answered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed colours for better accessibility for people with sight difficulties