Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

button tags #7003

Closed
wants to merge 1 commit into from
Closed

button tags #7003

wants to merge 1 commit into from

Conversation

kiritikishore
Copy link
Contributor

Added in buttons in order for the orca screen reader user to use the tab key to "click" on it.
is added for spacing.

@kiritikishore
button tags
5564f4c 
Added in buttons in order for the orca screen reader user to use the tab key to "click" on it.<br> is added for spacing.
@mattab
Copy link
Member

mattab commented Jan 14, 2015

Hi @itscutekk thanks for the Pull Request!

I've tested it and have some feedback

  • The button looks with a red background:
    button - instead it should look standard
  • when clicking the link "Add new website" it does not work anymore after button was added

@mattab mattab closed this Jan 15, 2015
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jan 15, 2015
@mattab mattab added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Feb 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kiritikishore @mattab