currently we don't check that the user has the zlib extension, but it is required for piwik to work correctly. We should add this check at installation.
Attachment:
700_check_zlib.patch
Attachment:
700_systemcheck.patch
Attachment: next try
700_gd_systemcheck.patch
Attachment: added spl check
700_spl_systemcheck.patch
Attachment: updated patch
700_spl_systemcheck.2.patch
Attachment: updated template file, no patch
systemCheck.tpl
Attachment: patch for template file
700_systemcheck_template.patch
i created another patch to reduce some code, only a suggestion... (if useful i will modify template too)
regards
pebosi: it looks good with the exception of the changes from lines 488-499. It looks like the version requirement has been reversed; meanwhile, there's no check when the gd extension is missing.
pebosi, your patch is hard to read as you removed all white spaces etc.
can you please submit patch against trunk for only the lines you modified?
actually we should also add SPL to the list of required extension as of #176
Looks good (except for some minor formatting). Can you update the systemCheck template too and test it?
attached an updated patch and the first version of tempalte file (no patch). i replaced the help text of gd and extension-check with a link to http://piwik.org/docs/requirements/ (needs to be updated then)... only a suggestion ;)
regards
Sorry for not reviewing this sooner.
We should add/keep the informative help messages (e.g., Installation_SystemCheckPdoHelp). Perhaps:
$needed_functions = array(
'set_time_limit' => 'Installation_SystemCheckTimeLimitHelp',
'mail' => 'Installation_SystemCheckMailHelp',
);
(In [1368]) fixes #700 - added check for zlib and SPL at install; based on pebosi's patch