Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3341] Add possibility to pass custom plot properties in request eg. canvasLegend #7

Closed

Conversation

chmielot
Copy link

Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Tests pass: -
Fixes the following tickets: #3341
Todo: -
License of the code: MIT

Use case: The canvas legend of pie charts doesn't make sense, actually. Currently a canvas legend with the word "visits" is shown. This patch prepares piwik to customize plot parameters. Plot parameters that should be allowed to be customized need to be added to Piwik_ViewDataTable::init() to the protected $plotProperties variable. Plot options are then fully under control of PIWIK and if desires arise to customize other parameters as well, they can easily be added. Of course modifications to jqplot.js are unavoidable to $.extend() the default settings.

Please review and tell if you can think of better implementations. This one seems pretty straight forward and transparent to me.

…equest

Everything is prepared and as a reasonable example, allow to turn
of canvas legend in jqplot.
@robocoder robocoder closed this Aug 26, 2012
@halfdan halfdan mentioned this pull request Jul 1, 2009
sgiehl added a commit that referenced this pull request Feb 13, 2024
sgiehl added a commit that referenced this pull request Feb 15, 2024
)

* [Coding Style] Enable rules PSR2.Methods.FunctionCallSignature.*

* Apply coding style around FunctionCallSignature #1 (#21927)

* Apply coding style around FunctionCallSignature #2 (#21928)

* Apply coding style around FunctionCallSignature #3 (#21929)

* Apply coding style around FunctionCallSignature #4 (#21930)

* Apply coding style around FunctionCallSignature #5 (#21931)

* Apply coding style around FunctionCallSignature #6 (#21932)

* Apply coding style around FunctionCallSignature #7 (#21933)

* Apply coding style around FunctionCallSignature #8 (#21934)

* Apply coding style around FunctionCallSignature #9 (#21935)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants