Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed view type for visitor log #6987

Merged
merged 6 commits into from Jan 20, 2015
Merged

Fixed view type for visitor log #6987

merged 6 commits into from Jan 20, 2015

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jan 12, 2015

This PR aims to fix #6928 by allowing to set a fixed view type for reports.

@mattab
Copy link
Member

mattab commented Jan 14, 2015

Hi @sgiehl - thanks for the PR!
looks good to me. @tsteur maybe you have some opinion as well?

@tsteur
Copy link
Member

tsteur commented Jan 15, 2015

I'm not sure re the name isDefaultTypeFixed. In the context of Report I would not think of a fixed ViewDataTable/Visualization.

Would maybe also rather check for isFixed... in https://github.com/piwik/piwik/blob/2.10.0/core/ViewDataTable/Factory.php#L92 instead of in report class then it works everywhere as ViewDataTabe::build is also called in other places. We are getting the report eg here: https://github.com/piwik/piwik/blob/2.10.0/core/ViewDataTable/Factory.php#L161

@sgiehl
Copy link
Member Author

sgiehl commented Jan 17, 2015

@tsteur better that way?

@tsteur
Copy link
Member

tsteur commented Jan 19, 2015

Sorry can you maybe rename isDefaultTypeFixed to something like alwaysUseDefaultViewDataTable or isViewDataTableFixed or maybe you have a better idea? I know it is not much better but a bit more consistent with getDefaultTypeViewDataTable for plugin developers. Not sure why I named it getDefaultTypeViewDataTable initially, not such a great name...

Side note: Would be nice to use for Piwik 3.0 the wording Visualization instead of ViewDataTable even if it is technically wrong (as the base class is currently called ViewDataTable which we would have to rename) but much more clearer for everyone what is meant.

@sgiehl
Copy link
Member Author

sgiehl commented Jan 19, 2015

@tsteur changed method name to alwaysUseDefaultViewDataTable. If everything is fine now, feel free to merge.

tsteur added a commit that referenced this pull request Jan 20, 2015
Fixed view type for visitor log
@tsteur tsteur merged commit 1b8d302 into master Jan 20, 2015
@tsteur tsteur deleted the 6928 branch January 20, 2015 01:58
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants