Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When the BulkTracking plugin is disabled, bulk imports succeed, but no data is imported #6982

Closed
rmoesbergen opened this issue Jan 12, 2015 · 2 comments
Closed

When the BulkTracking plugin is disabled, bulk imports succeed, but no data is imported #6982

rmoesbergen opened this issue Jan 12, 2015 · 2 comments
Assignees
@diosmosis
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
Piwik 2.11.0

Comments

@rmoesbergen
Copy link

When the BulkTracking plugin is disabled, the import_logs.py reports success when importing logfiles, but no data is actually imported. This may lead to unnoticed data loss. It would be better if the API reported an error when this plugin is disabled and a request for bulk importing data is done. I've reproduced this with version 2.10.0. Steps:

  1. Disable the BulkTracking plugin and restart the webservice/PHP-FPM
  2. Perform log imports using import_logs.py, the script will report 'OK'
  3. Perform an archive run, no visits will be imported
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Jan 14, 2015
@mattab mattab added this to the Piwik 2.11.0 milestone Jan 14, 2015
@mattab
Copy link
Member

mattab commented Jan 14, 2015

Hi @rmoesbergen thanks for the report

@tsteur
Copy link
Member

tsteur commented Jan 22, 2015

This needs to be fixed / handled in log importer as the behaviour in Piwik itself is correct/expected in this case. What Piwik does is returning a message like Piwik is a free/libre web analytics that lets you keep control of your data. in case it does not detect any request tracking data. So basically the log importer has to check whether the response is json and if not show an error maybe.

@diosmosis diosmosis self-assigned this Jan 24, 2015
@mattab mattab changed the title 2.10.0, When the BulkTracking plugin is disabled, bulk imports succeed, but no data is imported When the BulkTracking plugin is disabled, bulk imports succeed, but no data is imported Feb 16, 2015
@rmoesbergen rmoesbergen mentioned this issue Feb 16, 2015
Closed
@tsteur tsteur mentioned this issue Mar 31, 2015
Closed
@mattab mattab mentioned this issue Mar 31, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diosmosis diosmosis

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
Piwik 2.11.0
Development

No branches or pull requests
4 participants
@diosmosis @tsteur @mattab @rmoesbergen