New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currently selected Segment should be displayed in bold #6961

Closed

jantlwoomy opened this issue Jan 9, 2015 · 1 comment

Labels

Milestone

Contributor

jantlwoomy commented Jan 9, 2015

Currently selected Segment is not highlighted.
How to reproduce:

Create new Segment: name - Not Users, Metric: User ID, Match: Is, Value: Empty string
Click at the Segment drop-down.

Expected result: Not users should be highlighted with bold.
Actual result: Not users is the same as All visits (default)

There is two reasons:

CSS selectors
Incorrect JS in the Google Chrome that doesn't add "segmentSelected" class to the list item.

Please see https://github.com/jantlwoomy/piwik/compare/selected_segment_css#diff-e43aeb1ad6d1b908a927966027b16135L682

Member

sgiehl commented Jan 9, 2015

Feel free to create a pull request

jantlwoomy mentioned this issue

Selected segment css #6970

Merged

mattab added this to the Piwik 2.11.0 milestone

mattab added the c: Usability label

mattab closed this as completed

mattab changed the title ~~Selected Segment style~~ Currently selected Segment should be displayed in bold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment