Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date to load by default does not always work (regression) #6960

Closed
mattab opened this issue Jan 9, 2015 · 3 comments
Closed

Date to load by default does not always work (regression) #6960

mattab opened this issue Jan 9, 2015 · 3 comments
Assignees
@tsteur
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
Piwik 2.11.0

Comments

@mattab
Copy link
Member

mattab commented Jan 9, 2015

Reported in forum

I have the Piwik set to open a certain site when I login, and also display the data via the current month.

Issue was reproduced in 2.10.0.
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Jan 9, 2015
@mattab mattab added this to the Piwik 2.11.0 milestone Jan 9, 2015
@mattab
Copy link
Member Author

mattab commented Jan 9, 2015

also reported in http://forum.piwik.org/read.php?2,123290

@tsteur tsteur self-assigned this Jan 13, 2015
tsteur added a commit that referenced this issue Jan 13, 2015
@tsteur
refs #6960 fix date to load by default does not always work
b7f5e5c
@tsteur tsteur mentioned this issue Jan 13, 2015
Merged
@tsteur
Copy link
Member

tsteur commented Jan 13, 2015

The pull request fixes it but please be aware that it is partially broken by design.

There is an event UsersManager.getDefaultDates in https://github.com/piwik/piwik/blob/2.10.0/plugins/UsersManager/Controller.php#L199 that gets default dates and translations but this one is not considered in getDefaultDate https://github.com/piwik/piwik/blob/2.10.0/plugins/UsersManager/UserPreferences.php#L78 and getDefaultPeriod https://github.com/piwik/piwik/blob/2.10.0/plugins/UsersManager/UserPreferences.php#L101

It is not really possible to do this without breaking the API as the event does not contain information which date/period to use for a selected default date. As mentioned currently the event only returns a name and translation currently

@mattab
Copy link
Member Author

mattab commented Jan 14, 2015

Thanks for the issue. Bug was fixed.

@mattab mattab closed this as completed Jan 14, 2015
@sgiehl sgiehl mentioned this issue Jan 16, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
Piwik 2.11.0
Development

No branches or pull requests
2 participants
@tsteur @mattab