Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix User ID Segmentation #6954

Merged
merged 1 commit into from Feb 9, 2015

Conversation

jantlwoomy
Copy link
Contributor

Tried to segment all visits to Users and Not users.
Segmentation with rules User Id, Not equal, Empty generates next SQL:
( log_visit.idvisitor IS NOT NULL AND (log_visit.idvisitor <> '' OR log_visit.idvisitor = 0)

But in case Anonymous visitor there is Visitor ID but no User ID.

So after fix SQL changing for this:
( log_visit.user_id IS NOT NULL AND (log_visit.user_id <> '' OR log_visit.user_id = 0) )

@mattab
Copy link
Member

mattab commented Jan 9, 2015

Hi @jantlwoomy would you mind first creating an issue for the bug, with steps to reproduce, and expected results VS got result? and please link #6954 from your issue. I'm not sure that this change is valid, but let's see! cheers

@mattab mattab closed this Jan 9, 2015
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Jan 9, 2015
@mattab
Copy link
Member

mattab commented Feb 9, 2015

Thanks @jantlwoomy for the PR!

Fixes #6959

@mattab mattab reopened this Feb 9, 2015
mattab pushed a commit that referenced this pull request Feb 9, 2015
@mattab mattab merged commit 25409d6 into matomo-org:master Feb 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants