Splitted referrers overview into "Overview" and "All Referrers" #6945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattab
pushed a commit
that referenced
this pull request
Jan 7, 2015
Splitted referrers overview into "Overview" and "All Referrers"
|
FYI: I updated oTrance |
tsteur
added
the
c: Usability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the UI cleaner...
Overview itself got cleaner and we could remove the "more details" link and just always show all sparklines.
The two reports below the overview were moved into "All Referrers" containing a report "Referrer Types" and "Referrers". I removed the "By dimension view" as it was only duplicated anyway. In "Referrers" all columns are now shown by default so that both reports have the same width. Names of the titles could be changed later. "Referrer Type" was often or always used elsewhere so I reused that naming.
After merging we need to update translations, fix UI tests and add a UI test for "all referrers"