Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a plugin requires a core piwik version that does not exist yet, CI tests start timing out #6941

Closed
mattab opened this issue Jan 7, 2015 · 8 comments
Closed

When a plugin requires a core piwik version that does not exist yet, CI tests start timing out #6941

mattab opened this issue Jan 7, 2015 · 8 comments
Labels
answered For when a question was asked and we referred to forum or answered it. Bug For errors / faults / flaws / inconsistencies etc. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues.
Milestone
Backlog (Help wan...

Comments

@mattab
Copy link
Member

mattab commented Jan 7, 2015

The goal of this issue is to fix the bug that when a core Piwik version is specified in a plugin and this core version does not exist yet (eg. 4.0.0), then Piwik runs very slow (at least during tests). We expect that Piwik behaves still the same independently of the required core versions.

Explanation

Yesterday our builds started failing due to timing out. See here:

half of them take 50min and before used to take 25min

I wrote email to Travis support as I was sure it was infrastructure problem, but as usual, it was a bug in the code. ;-) at first we got super confused as we looked at the wrong commit (N-1 instead of N). After that with matt we looked again and it was worked around in commit: matomo-org/plugin-CustomAlerts@0e88064 then the build behaved again.

cc @tsteur @mnapoli
@mattab mattab added Bug For errors / faults / flaws / inconsistencies etc. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. labels Jan 7, 2015
@mattab mattab added this to the Short term milestone Jan 7, 2015
@mnapoli
Copy link
Contributor

mnapoli commented Jan 7, 2015

For the record in the plugin I required a version that doesn't exist. The reason is that 2.10.0 is not compatible, I needed dev-master (but we don't support such constraint in plugin.json) so I opted for 2.11.0-b1. The commit to fix reverts to 2.10.0 even though that version constraint is not correct.

@tsteur
Copy link
Member

tsteur commented Jan 7, 2015

You could try to disable the Marketplace in tests and see if it changes anything. Otherwise it is not good to require a Piwik version that is not released yet. Eg Piwik would notice there is a missing dependency and deactivate the plugin which can cause failing tests (at least the UI tests).

@mattab
Copy link
Member Author

mattab commented Jan 7, 2015

Maybe the piwik would have behaved better if the Version.php already contained 2.11.0-b1 (even though the version was not released yet.). I changed the version in: 52c93bb and will now try to revert matomo-org/plugin-CustomAlerts@0e88064 and see if the build is working.

edit: this build https://travis-ci.org/piwik/piwik-ui-tests/builds/46155835

mattab pushed a commit to matomo-org/plugin-CustomAlerts that referenced this issue Jan 7, 2015
require 2.11.0-b1 refs matomo-org/matomo#6941
c631cc0
mattab added a commit that referenced this issue Jan 7, 2015
@mattab
CustomAlerts requires 2.11.0-b1 which is not yet released refs #6941
ad1a341
@mnapoli
Copy link
Contributor

mnapoli commented Jan 7, 2015

This is not good but what would be the good way?

@tsteur
Copy link
Member

tsteur commented Jan 7, 2015

Increase Piwik version

@mattab
Copy link
Member Author

mattab commented Jan 7, 2015

I can confirm that it works to require 2.11.0-b1 and then set this version number in core/Version.php

we don't need to create a tag. so maybe this is acceptable solution.

@tsteur
Copy link
Member

tsteur commented Jan 7, 2015

I think it is not only an acceptable but also the correct solution. If you have changes in Piwik that changes the API then you increase the version number.

@mattab
Copy link
Member Author

mattab commented Jan 7, 2015

👍

Conclusion is: when we set a Piwik require version then we must set this version in core/Version.php - makes sense, but it wasn't clear before. Maybe we should write this somewhere...

@mattab mattab closed this as completed Jan 7, 2015
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Jan 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
answered For when a question was asked and we referred to forum or answered it. Bug For errors / faults / flaws / inconsistencies etc. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
3 participants
@tsteur @mattab @mnapoli