Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Administrator link to top menu #6937

Merged
merged 1 commit into from Jan 7, 2015
Merged

Add Administrator link to top menu #6937

merged 1 commit into from Jan 7, 2015

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jan 7, 2015

As title says goal was to add administrator link to top menu. To make this possible we made several changes...

  • added an administration link in top menu
  • moved logout to user menu, we know this is kinda an anti pattern but it should be ok as users can decide whether login should be remembered. We did this to keep the top menu small as we added the Admin link
  • renamed some settings links in admin menu (removed the duplicated "Settings" wording)
  • Moved the hardcoded login/logout links out of the template to a Menu class. This allows plugins to add the logout to the top menu again and to remove it from the user menu etc

After merge: We need to add new translation key to oTrance: General_General and UsersManager_AnonymousUser

@tsteur tsteur changed the title Several top/admin menu changes Add Administrator link to top menu Jan 7, 2015
@tsteur
Copy link
Member Author

tsteur commented Jan 7, 2015

Translation keys added to oTrance...

tsteur added a commit that referenced this pull request Jan 7, 2015
Add Administrator link to top menu
@tsteur tsteur merged commit 2f79796 into master Jan 7, 2015
@tsteur tsteur deleted the menuchanges branch January 7, 2015 00:18
@tsteur tsteur added c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. labels Jan 7, 2015
@tsteur tsteur added this to the Piwik 2.11.0 milestone Jan 7, 2015
@tsteur tsteur self-assigned this Jan 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant