Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve device model & brand reports #6933

Closed
sgiehl opened this issue Jan 6, 2015 · 4 comments
Closed

Improve device model & brand reports #6933

sgiehl opened this issue Jan 6, 2015 · 4 comments
Assignees
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. RFC Indicates the issue is a request for comments where the author is looking for feedback.
Milestone

Comments

@sgiehl
Copy link
Member

sgiehl commented Jan 6, 2015

We should try to improve the current reports for device brands and models.

Device models are currently reported without any associations to their related brand. As some device names are ambiguous the current report is not as accurate as it could be.
Instead we maybe should display kind of combined report showing brand and model.

In addition it would maybe make sense to add subtables to the brand report, reporting all models for the specific brands.

@sgiehl sgiehl added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Jan 6, 2015
@tzi
Copy link
Member

tzi commented Jan 6, 2015

There is currently two tables: "Device brands" and "Device models".
Like you said, I don't think that "Device models" is usable for now, because of the ambiguous names (201, D802, F220K, etc.).
device-names

Adding the device models as the brand subtable seems to be a good solution.
What we have to do with the device model table it-self?

  • Prefix the device model with the brand, to provide the device model order that the device brand grouping removed.
  • Remove the device models table from the device page, if we think it is not usable

I think we should try to have a more consistent device page. For now:

  • The browser brand has no subtable for the browser versions. We only show brower brand.
  • The operating systems are not grouped by brand. We only show operating models.
  • The device brand has no subtable for the device models. We show both device brand and device models.

Cheers,
Thomas

@sgiehl sgiehl added the RFC Indicates the issue is a request for comments where the author is looking for feedback. label Jan 7, 2015
@mattab
Copy link
Member

mattab commented Feb 19, 2015

Device models are currently reported without any associations to their related brand. As some device names are ambiguous the current report is not as accurate as it could be.
Instead we maybe should display kind of combined report showing brand and model.

Maybe it would be enough to change the Device Model report and set the label to Brand - Model instead of just Model ?

In addition it would maybe make sense to add subtables to the brand report, reporting all models for the specific brands.

Sounds good, although maybe it could be done as "next step" as already pre-pending the Device Brand to the Model, would be huge improvement I think 👍

@mattab mattab added this to the Piwik 2.12.0 milestone Feb 19, 2015
mnapoli added a commit that referenced this issue Mar 11, 2015
…he brand name

E.g. 'iPad' would become 'Apple - iPad'
@mnapoli mnapoli self-assigned this Mar 11, 2015
@mattab mattab modified the milestones: Piwik 2.12.0, Piwik 2.13.0 Mar 11, 2015
mnapoli added a commit that referenced this issue Mar 15, 2015
…he brand name

E.g. 'iPad' would become 'Apple - iPad'
@mnapoli mnapoli removed their assignment Apr 1, 2015
@mnapoli
Copy link
Contributor

mnapoli commented Apr 1, 2015

@mattab should we close this now that the PR is merged?

@mattab
Copy link
Member

mattab commented Apr 1, 2015

device model

Yes, looks good 👍

@mattab mattab closed this as completed Apr 1, 2015
@mnapoli mnapoli self-assigned this Apr 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. RFC Indicates the issue is a request for comments where the author is looking for feedback.
Projects
None yet
Development

No branches or pull requests

4 participants