Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visitor log may be displayed with many columns #6928

Closed
mattab opened this issue Jan 6, 2015 · 12 comments
Closed

Visitor log may be displayed with many columns #6928

mattab opened this issue Jan 6, 2015 · 12 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
Piwik 2.11.0

Comments

@mattab
Copy link
Member

mattab commented Jan 6, 2015

It was reported in the forums (and several more posts) that the Visitor Log can appear broken with many columns displayed instead of only 3 columns.

To reproduce the issue you can edit the table preference setting with:

UPDATE `piwik`.`piwik_option` SET `option_value` = '{"isFooterExpandedInDashboard":true,"filter_limit":100,"viewDataTable":"table"}' WHERE `piwik_option`.`option_name` = 'viewDataTableParameters_root_Live.getLastVisitsDetails';

where root is your username. Setting "viewDataTable":"table" creates the bug.

Maybe this is caused because the Visitor Log uses a custom table visualisation with an ID of 'Piwik\Plugins\Live\VisitorLog' and it expected this viewDataTable value?
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Jan 6, 2015
@mattab mattab added this to the Piwik 2.11.0 milestone Jan 6, 2015
@sgiehl
Copy link
Member

sgiehl commented Jan 6, 2015

Maybe could implement to set a "fixed" view type for a report, that can't be changed by settings in db or url.

@warenhaus
Copy link

mattab, are you saying that one could change the preference setting via sql to a setting that "unbreaks" the log? (i.e., displaying only 3 columns)

what setting would that be?

@sgiehl sgiehl added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Jan 7, 2015
@mattab
Copy link
Member Author

mattab commented Jan 9, 2015

loads of people have this issue in the forums.

Maybe could implement to set a "fixed" view type for a report, that can't be changed by settings in db or url.

👍

sgiehl added a commit that referenced this issue Jan 12, 2015
@sgiehl
refs #6928 - set fixed view type for visitor log
037c64e
@sgiehl sgiehl mentioned this issue Jan 12, 2015
Merged
@sgiehl sgiehl self-assigned this Jan 12, 2015
@dmsz
Copy link

dmsz commented Jan 15, 2015

i have the same issue with a brand new installation of piwik 2.10.0.
Visitor log is raw data table with text only no images or text formatting..
PHP version is 5.3.27. I will ask them to upgrade it and we'll see what happens then.

@dmsz
Copy link

dmsz commented Jan 15, 2015

unortunately the previous fix for view type has not solved the problem for me.

@sgiehl
Copy link
Member

sgiehl commented Jan 15, 2015

Did you apply the patch? The changes are currently not merged to master.
You also may need to clear tmp directory of piwik as the broken layout might be cached.

@dmsz
Copy link

dmsz commented Jan 15, 2015

i changed the 2 files according to #6987 but the visitor log remains a raw data table with text only.
tried it twice but no success.

@sgiehl
Copy link
Member

sgiehl commented Jan 15, 2015

Hm. That's weird. I'm not able to reproduce that on my local machine.

@dmsz
Copy link

dmsz commented Jan 15, 2015

it is strange indeed, i tried to install a third time again, the system check passed without a warning, but the visitor log is just the same table with text.

@sgiehl sgiehl removed their assignment Jan 16, 2015
@sgiehl
Copy link
Member

sgiehl commented Jan 16, 2015

I've tried to investigate that a bit more. Besides having an incorrect view set in the options table (which would be fixed by the PR), I'm not able to reproduce that error.
I've also tried that on PHP 5.3.27, 5.4.36 and 5.5.20. All with the same behavior.

@ghost
Copy link

ghost commented Jan 17, 2015

Hey, I just wanted to note that we have been experiencing exactly the same problem and were able to nicely fix it by applying patch #6987. Thank you so much for your work, and I hope the next version will be released soon for others who might not see this patch. ^.^

@dmsz
Copy link

dmsz commented Jan 19, 2015

Thank you guys, the modified fix worked. I am very thankful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
Piwik 2.11.0
Development

No branches or pull requests
4 participants
@mattab @warenhaus @sgiehl @dmsz