Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple commands classes components detector #6922

Closed
wants to merge 1 commit into from
Closed

Multiple commands classes components detector #6922

wants to merge 1 commit into from

Conversation

czolnowski
Copy link
Contributor

Hello team,

I remove hardcoded class name and replace them with hook. I suppose that is more universal and easier to maintain than path to EnterpriseAdmin plugin class.

@mattab mattab added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Jan 6, 2015
@tsteur
Copy link
Member

tsteur commented Jan 22, 2015

I do not really understand this change. Do you mind explaining why we need to events to detect and filter commands? In theory people could add their own commands using the filterCommands event if needed (which would be probable only the Enterprise plugin). Normal expected behaviour would be that plugins place the Command in the correct folder. If I remember correct Enterprise plugin was a special case as it is used when Piwik is not yet installed or so? So using the filterCommands event here seems ok for me

@mattab
Copy link
Member

mattab commented Feb 7, 2015

Hi @czolnowski is this PR in progress, maybe you have a question? if not feel free to close

@czolnowski czolnowski closed this Feb 10, 2015
@mattab mattab mentioned this pull request Feb 16, 2015
Closed
@mattab mattab added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Feb 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@czolnowski @tsteur @mattab