Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click tracker piwik.php?redirect=[params] was not working #6918

Closed
johnefemer opened this issue Jan 5, 2015 · 3 comments
Closed

Click tracker piwik.php?redirect=[params] was not working #6918

johnefemer opened this issue Jan 5, 2015 · 3 comments
Assignees
@mnapoli
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
Piwik 2.11.0

Comments

@johnefemer
Copy link

i noticed the target link was not redirecting to the outlink after tracking the interaction.

redirecturl=https%3A%2F%2Fmyhost.com&c_i=click&c_n=FREE%20TShirts&c_p=414%7C0%7CFREE%20TShirts&c_t=https%3A%2F%2Fmyhost.com&idsite=4&rec=1&r=360231&h=13&m=9&s=2&url=https%3A%2F%2Fmyhost.com%2F&_id=731f778e6984d599&_idts=1420410246&_idvc=2&_idn=0&_refts=0&_viewts=1420410526&send_image=0&pdf=1&qt=0&realp=0&wma=0&dir=0&fla=1&java=1&gears=0&ag=0&cookie=1&res=3360x2100&gt_ms=790

it seems theres no header 301 in the Url.php,
i added the following line before line 486,

            Common::sendHeader("HTTP/1.1 301 Moved Permanently");

now its redirecting to the target.
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Jan 5, 2015
@mattab mattab added this to the Piwik 2.11.0 milestone Jan 5, 2015
@mattab
Copy link
Member

mattab commented Jan 5, 2015

Hi @johnefemer thanks for the report!

@tsteur
Copy link
Member

tsteur commented Jan 13, 2015

Shouldn't it be a 302 Not Found / Moved Temporarily or since HTTP 1.1 a 307 Temporary Redirect?

@mattab
Copy link
Member

mattab commented Jan 14, 2015

302 http redirect sounds good

@mnapoli mnapoli self-assigned this Jan 16, 2015
@mattab mattab changed the title Click tracker piwki.php?redirect=[params] was not working Click tracker piwik.php?redirect=[params] was not working Feb 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnapoli mnapoli

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
Piwik 2.11.0
Development

No branches or pull requests
4 participants
@tsteur @mattab @mnapoli @johnefemer