Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename plugin management commands #6915

Closed
mnapoli opened this issue Jan 4, 2015 · 4 comments
Closed

Rename plugin management commands #6915

mnapoli opened this issue Jan 4, 2015 · 4 comments
Assignees
@mnapoli
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
Piwik 2.11.0

Comments

@mnapoli
Copy link
Contributor

mnapoli commented Jan 4, 2015

As discussed in #6801 it would be good to rename the following commands:

  • core:plugin activate in plugin:activate
  • core:plugin deactivate in plugin:deactivate
  • plugin:list (not sure if this one needs to be renamed or created)

Also:

The ManagePlugin.php command contains actually 3 commands and should be refactored into 3 actual commands, meaning 3 files.
@mnapoli mnapoli added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. labels Jan 4, 2015
@mnapoli mnapoli added this to the Piwik 2.11.0 milestone Jan 4, 2015
@mnapoli mnapoli mentioned this issue Jan 4, 2015
Closed
@mnapoli
Copy link
Contributor Author

mnapoli commented Jan 4, 2015

Also updating the docs with the new commands would solve the original problems of #6801.

@mattab
Copy link
Member

mattab commented Jan 5, 2015

If we can keep BC for existing scripts using core:plugin it would be nice... if not possible, let me know

mnapoli added a commit that referenced this issue Jan 11, 2015
@mnapoli
#6915 Renamed plugin management commands
636d540
@mnapoli mnapoli self-assigned this Jan 11, 2015
@mnapoli
Copy link
Contributor Author

mnapoli commented Jan 11, 2015

Commands renamed + plugin:list displayed as a table with a few information:

capture d ecran 2015-01-12 a 12 38 51

I'll update the developer docs.

@mnapoli mnapoli closed this as completed Jan 11, 2015
@mattab
Copy link
Member

mattab commented Jan 11, 2015

oh, a pretty table! nice change 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnapoli mnapoli

Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
Piwik 2.11.0
Development

No branches or pull requests
2 participants
@mattab @mnapoli