Data files: removed usage of $GLOBALS and manual inclusions #6912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnapoli
added
the
c: Platform
|
All good for review and merge after #6909 is merged! |
|
The tests pass on Travis but on 5.3.3 the sh script ends with a segfault :/ I have no idea what's going on, everything seems fine (tests are all OK) |
|
needs to be rebased, Looks good to me! |
mnapoli
force-pushed
the
intl-data
branch
2 times, most recently
from
4eac34f
to
187fa36
Compare
|
Please review the last commit (de53c1b306): it solved the eternal "MySQL server has gone away" (at least here). If OK, then it's good to be merged. |
Less code in `Piwik\Common`, less static classes, more isolated components.
mattab
pushed a commit
that referenced
this pull request
Jan 9, 2015
Data files: removed usage of $GLOBALS and manual inclusions
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #6909 which explains the commit history and the big diff.
I've moved data files related to internationalization into the new
Intlcomponent (introduced in #6909) just like in Symfony's Intl component.Previously, those data files were manually included, and
$GLOBALSwas used. Now it's been replaced with classes.