Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6765 Moved the 'Settings' menu in the top menu #6892

Closed
wants to merge 1 commit into from

Conversation

mnapoli
Copy link
Contributor

@mnapoli mnapoli commented Dec 22, 2014

The settings menu is now visible on every page and doesn't require to click on the user name.

As I said on #6765, the first times I used Piwik I was very confused because I couldn't find this link.

capture d ecran 2014-12-23 a 10 28 47

The settings menu is now visible on every page and doesn't require to click on the user name.
@mnapoli mnapoli added the c: Usability For issues that let users achieve a defined goal more effectively or efficiently. label Dec 22, 2014
@mnapoli mnapoli self-assigned this Dec 22, 2014
@tsteur
Copy link
Member

tsteur commented Dec 22, 2014

Maybe it can be reordered? Settings seems to me like the most unimportant link there as one usually does not need it very often. It is different for us core developers as we work in all areas all the time. A regular end user should hopefully not having to deal with it, apart from the initial setup.

@tsteur
Copy link
Member

tsteur commented Dec 22, 2014

It looks also kinda messy with the Settings link. Like unneeded clutter. I liked how clean it was before considering that Settings are rarely needed. Maybe there are other solutions? I know @mattab likes to see the user name there but maybe we can leave the Settings link in the popup and just rename the original link which opens this menu (that contains the user name) with "More" or something else. Most items under the username are not really user related anyway.

@mattab
Copy link
Member

mattab commented Dec 22, 2014

maybe we could leave the Settings link in the expanded menu and expand the top menu on hover

Alternative if we dont want to display the username on the screen, we could move this username in the expanded menu, and replace the username label by Settings instead?

@mattab mattab added this to the Piwik 2.11.0 milestone Dec 22, 2014
@mattab mattab added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Dec 22, 2014
@tsteur
Copy link
Member

tsteur commented Dec 22, 2014

I think if we'd rename from username to something like "More" we could have an item Settings in the Menu or Administration or Configure Piwik or Piwik Settings and on top the user name which let's one directly configure the users personal settings. Alternatively could be named "Personal Settings"

@mnapoli
Copy link
Contributor Author

mnapoli commented Dec 23, 2014

Imagine you are a first time user of Piwik:

  • you download and install Piwik
  • during the installation you end up installing 1 site
  • installation done, you can see graphs, OK
  • then you want to install a second site or see what you can configure -> 💥

What I consider confusing is the fact that "Settings" and "User settings" are the same thing. Most of the time I don't care about my own profile, but administrating Piwik is a major use case (in my experience I either look at reports or change Piwik settings).

A suggestion:

  • Dashboard
  • All websites (never liked this button here because the site selector is elsewhere)
  • More >
    • Administration (links to "General settings")
    • Manage (what does this even do? it's always greyed out on my installs)
    • Email reports
    • Platform (greyed out again, what is this?)
    • Marketplace: this is redundant with the Admin page, why do we link this one and not the other pages of the admin page?
  • Help
  • User name >
    • Profile settings
    • Sign out

If user is logged out, then "User name" is replaced with "Sign in".

I've removed the "API" menu from the list because it's only useful to developers. There's a "Developers" section in the admin page where this could fit better IMO.

I've also removed "Help" from the user menu because it was duplicated with the "Help" link in the top menu.

Thoughts?

@tsteur
Copy link
Member

tsteur commented Dec 23, 2014

Sure for first time users it is difficult to find but this problem can be probably solved differently.

I think Logout should be still a standalone action. At least it was discussed here and the following comments: #4987 (comment)

As then the user name menu has only one item personal settings I would move it into "More".

I think "All Websites" link makes sense to have it there. Otherwise it would be too hard to discover and people use it quite often. It could be hidden in case one has only one website (maybe it is already done? don't know).

👍 for splitting Administration and User Settings in general as mentioned before.

Manage / Platform greyed out are simply category names similar to eg the Chrome menu on Mac etc.

I'd probably leave API there. We often tell users to go to the API page to find their token_auth. Maybe the link can be removed. As it is under "More" I don't feel so annoyed by this link. It could link to "Developer" instead of "API" but the current "Development" category and their items are only displayed when developer mode is enabled. The "API" should be always present. People also use it for Excel and RSS export I reckon

@mattab
Copy link
Member

mattab commented Dec 28, 2014

I've removed the "API" menu from the list because it's only useful to developers.

The "API" should be always present. People also use it for Excel and RSS export I reckon

yes it's useful to keep API in the sub-menu because it's the way that users can get their token_auth and we document it on many guides eg. http://piwik.org/faq/general/faq_114/ (If we move out API we'd have to update all faqs/guides that explain to click on top menu link "API" to get the token_auth...). maybe we change it later after we fix other issues in the menu ;)

@mnapoli
Copy link
Contributor Author

mnapoli commented Jan 1, 2015

After thinking about it, given the "user menu" is a different menu from the top one (code-wise) it would break things. And the work needed to change all the docs, faqs, …

Closing this, if anyone else has more motivation to go through all this feel free

@mnapoli mnapoli closed this Jan 1, 2015
@mnapoli mnapoli deleted the settings-menu branch January 1, 2015 00:43
@mattab mattab added the wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it. label Jan 5, 2015
@tsteur
Copy link
Member

tsteur commented Jan 5, 2015

Just in case someone reads this later... What I find confusing is the menu item name "Settings" itself. Clicking on "Settings" opens a page that shows "Manage", "Settings", "Platform", "Diagnostic", ... so naming this item "Settings" seems to be kinda wrong as it is only one part. In that menu that is shown when clicking on user it also contains categories like "Manage" and "Platform". It seems like there is something wrong.

A better name could be maybe "Administration" or something else. Maybe we could otherwise directly display the Admin menu there? but then it would be a long list in this "user menu"...

@mattab
Copy link
Member

mattab commented Jan 5, 2015

see #6917

@mattab mattab added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Feb 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants