Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use transientcache once #6867

Merged
merged 2 commits into from Dec 17, 2014
Merged

Use transientcache once #6867

merged 2 commits into from Dec 17, 2014

Conversation

mattab
Copy link
Member

@mattab mattab commented Dec 17, 2014

Use the new PiwikCache::getTransientCache() to store the values instead of using the static array - these are called 50 K times or more when only 100 websites when rendering a scheduled report.

…ad of using the static array - these are called 50 K times or more when only 100 websites when rendering a scheduled report
@mattab
Copy link
Member Author

mattab commented Dec 17, 2014

Note: I should add some test that check that the cache is really used, eg.
https://github.com/piwik/piwik/blob/master/plugins/SitesManager/tests/Integration/SiteUrlsTest.php#L111

mattab pushed a commit that referenced this pull request Dec 17, 2014
@mattab mattab merged commit 0ca1479 into master Dec 17, 2014
@mattab mattab added the worksforme The issue cannot be reproduced and things work as intended. label Dec 17, 2014
@mattab mattab deleted the use_transientcache_once branch December 18, 2014 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants