Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module and action forwarding to prevent BC break does not work for Image Graphs #6865

Closed
mattab opened this issue Dec 16, 2014 · 1 comment
Closed

Module and action forwarding to prevent BC break does not work for Image Graphs #6865

mattab opened this issue Dec 16, 2014 · 1 comment
Assignees
@mattab
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
2.10.0

Comments

@mattab
Copy link
Member

mattab commented Dec 16, 2014

The goal of this issue is that when we deprecate plugins and APIs and introduce a forward between the old modules and the new ones (to keep backward compatibility) then these forwards should apply in all cases, and in particular in the ImageGraph plugin.

Currently the graph generates an error: http://demo.piwik.org/index.php?module=API&method=ImageGraph.get&idSite=3&apiModule=UserSettings&apiAction=getBrowser&token_auth=anonymous&graphType=horizontalBar&period=month&date=today&width=500&height=250

message is Invalid API module and/or API action

Proposed steps

  • fix the issue
  • and maybe we can build a generic tool for define those module forwards that can be reused in the future when more deprecation occur?

(out of scope: later we could add an integration test case for it in #6864 )

cc @sgiehl
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Dec 16, 2014
@mattab mattab added this to the Piwik 2.10.0 milestone Dec 16, 2014
@mattab
Copy link
Member Author

mattab commented Dec 17, 2014

Btw it can be seen on the following developer guide where the resolution graphs are used as example http://developer.piwik.org/api-reference/reporting-api-metadata#static-image-graphs

@mattab mattab self-assigned this Dec 17, 2014
mattab added a commit that referenced this issue Dec 18, 2014
@mattab
Fixes #6865 Introducing new event to let plugin define deprecated mod…
04b462f 
…ule and action
@mattab mattab mentioned this issue Dec 18, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattab mattab

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
2.10.0
Development

No branches or pull requests
1 participant
@mattab