Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error while trying to invalidate reports with raw data removal enabled #6859

Closed
mgazdzik opened this issue Dec 16, 2014 · 1 comment
Closed
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@mgazdzik
Copy link
Contributor

It seems that there is parameter misuse while invalidating old reports.
In https://github.com/piwik/piwik/blob/master/core/DataAccess/ArchiveInvalidator.php#L139
used parameter only says how often reports are being purged, and not for what time window. This causes that for ex. having this set to 1 day practically prevents any reports from being invalidated, regardless what is actual time window for removing old data.
I think that this parameter should be replaced with delete_logs_older_than days.

Steps to reproduce error:

  • enable raw data removing
  • try to invalidate reports older than 1 week (default data removal interval)
  • should cause exception and prevent reports from being invalidated, even though raw data should be still in database
@mgazdzik mgazdzik added the Bug For errors / faults / flaws / inconsistencies etc. label Dec 16, 2014
@mattab
Copy link
Member

mattab commented Dec 17, 2014

Hi @mgazdzik - that's a great find! thanks for the report.

@mattab mattab added this to the Piwik 2.10.0 milestone Dec 17, 2014
@mattab mattab closed this as completed in ab2b30d Dec 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants