Cloudfront log importing support and W3CExtendedFormat refactor #6851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| # if the --w3c-time-taken-secs option is used, make sure the time-taken field is interpreted as seconds | ||
| if config.options.w3c_time_taken_in_secs: | ||
| expected_fields['time-taken'] = '(?P<generation_time_secs>\S+)' | ||
| # if the --w3c-time-taken-millisecs option is used, make sure the time-taken field is interpreted as seconds |
There was a problem hiding this comment.
make sure the time-taken field is interpreted as seconds
, make sure the time-taken field is interpreted as milliseconds
added 2 commits
December 14, 2014 19:30
…r & making W3cExtendedFormat treat time-taken field as seconds by default (since that is what the W3C format specifies). Also add support for event tracking and cloudfront RTMP logs (which provide event logs). Also allow multiple spaces in between W3C extended log files. Allow derived classes of W3cExtendedFormat to define new custom field regexes.
diosmosis
force-pushed
the
cloudfront_and_iis_bugfix
branch
from
191cb8d
to
04f64ac
Compare
…to Parser.check_format so only one warning outputted.
diosmosis
added a commit
that referenced
this pull request
Dec 15, 2014
Cloudfront log importing support (web + RTMP) and W3CExtendedFormat refactor (allow derived types to modify recognized fields and interpret time-taken as seconds by default).
This was referenced Dec 15, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A refactor to the W3cExtendedFormat log format that:
Includes support for both normal web Amazon Cloudfront logs and Amazon Cloudfront RTMP logs, also. Multiple spaces are now allowed between fields in the W3C extended log file format.
Note: RTMP logs are logs for Amazon Cloudfront's RTMP streaming service. Reference is here: http://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/AccessLogs.html#StreamingDistributionLogFileFormat
RTMP logs contains logs for video playback events. They define some extra fields that for event information. This pull request will recognize those fields and supply them as event tracking query parameters.