create new visit on different campaign info or different referrer website #6847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 9, 2014 17:01
…paign/website referrer information changes between actions. Includes new tracker hook shouldForceNewVisit that dimensions can use to force a new visit during tracking. Also includes light refactoring to referrer dimensions. Testless.
…ferrer info present in last action. Also add integration + system tests for new behavior.
| ; if set to 1, actions that contain different campaign information from the last action in the current visit will | ||
| ; be treated as the start of a new visit. This will include situations when campaign information was absent before, | ||
| ; but is present now (or vice versa). | ||
| tracker_create_new_visit_when_campaign_changes = 1 |
There was a problem hiding this comment.
dont need to prefix with tracker_ since it's [Tracker] section
|
Feedback inline, nice change |
mattab
added
the
Enhancement
| @@ -550,6 +542,23 @@ private function triggerHookOnDimensions($dimensions, $hook, $visitor, $action, | |||
| return $valuesToUpdate; | |||
| } | |||
|
|
|||
| private function triggerPredicateHookOnDimensions($dimensions, $hook, Visitor $visitor, Action $action = null, $returnFirstTrue = true) | |||
| { | |||
| $result = $returnFirstTrue ? false : array(); | |||
There was a problem hiding this comment.
could we maybe remove $returnFirstTrue feature, it's not used and makes it bit hard to understand
added 4 commits
December 12, 2014 15:43
…ve shouldForceNewVisit to VisitDimension and simplify triggerPredicateHookOnDimensions.
diosmosis
pushed a commit
that referenced
this pull request
Dec 12, 2014
Create new visit on different campaign info or different referrer website (includes minor refactoring to Referrer dimensions + 2 new INI config options).
|
Added FAQ to document this feature: https://piwik.org/faq/how-to/faq_19616/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix issue #2624.