@tsteur opened this Issue on December 11th 2014 Member

Currently, only a super user can create a segment that is visible to all users but I think it makes sense to let admins select this as well as an admin can also create users etc. The other two options (displayed for all websites and archive yes/no) should still be only configurable for a super user.

@mattab commented on December 15th 2014 Member

as an admin can also create users

actually no: to create users you must be Super User...

let admins select this as well as an admin can also create users

The reason it was not done is that it would let any admin user impact the features of all view users. So imagine if you are a web agency and have 10 clients in your Piwik server. These users are set as admin so they can add their own users etc. if one of those 10 admins could also share segments with all view users, then one of the 10 clients could share data with other 9 clients (and any view users they created) without realising. Also those 9 admin users don't care about the segment from this other admin user...

This is maybe a wider issue with Piwik permissions that we could think about at some point. See also the popular #4314

@tsteur commented on December 15th 2014 Member

Don't see it like this. And users actually ask for it especially when in a cloud. You can't give everyone super user permission just for this. I don't think there are always so many admins that create so many different segments. Maybe it is then rather an issue to let admins and super users select whether they want to share it with other users or not.

@mattab commented on December 15th 2014 Member

I got a bit confused by the issue title which mentions "all users" but IMO it's not possible to let an admin user impact all users. So maybe the following works?

  1. An admin user should not be able to choose and displayed for ALL WEBSITES
  2. An admin user should not be able to set This segment is visible to: ALL USERS
    • 1) and 2) are already implemented
  3. An admin user should be able to share a segment by clicking This segment is visible to: USERS VIEWING THIS WEBSITE.

is 3. what you had in mind?

@tsteur commented on December 15th 2014 Member

yep, 3 is what I had in mind. With all users system wide wouldn't make any sense but with all users having access to that website

@mattab commented on March 3rd 2015 Member

Slightly related to #6766

@crazy-max commented on May 31st 2018

Really need this feature please !

@mattab commented on May 31st 2018 Member

We won't be working on it soon, so pull request welcome!

@crazy-max commented on May 31st 2018

@mattab After reading many issues concerning permissions i think the permission / user manager implementation has to be refactored. We should have X roles implemented for each site. Roles could be powered by the core and plugins using the permissions management API. Maybe open a new issue to discuss about this ?

@mattab commented on May 31st 2018 Member

we don't want to refactor or introduce more complex permission system in this particular issue here (this may be a good idea, but not the scope of this "simple" issue). So we still want to allow admin to create segments visible to all users having access to a website, and this could be implemented without considering the whole refactor

@crazy-max commented on May 31st 2018

ok i understand

Powered by GitHub Issue Mirror