Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail when the codebase version is older than the Piwik database schema version #6829

Closed
mattab opened this issue Dec 9, 2014 · 2 comments
Closed

Fail when the codebase version is older than the Piwik database schema version #6829

mattab opened this issue Dec 9, 2014 · 2 comments
Assignees
@mattab
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.10.0

Comments

@mattab
Copy link
Member

mattab commented Dec 9, 2014

Follows up #6815 which was a bug triggered by the fact that Piwik codebase 2.8.0 was running with a database schema of 2.9.1 causing invalid data to be inserted in the database.

Maybe when Piwik codebase is running an older version than the Schema version, we fail, to prevent such bugs from occurring.
@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Dec 9, 2014
@mattab mattab added this to the Piwik 2.10.0 milestone Dec 9, 2014
@mattab
Copy link
Member Author

mattab commented Dec 9, 2014

In case really wants to run the old codebase with the new schema, we could write a message explaining that there are risks to damage the database but it is possible to disable the error message by executing the command UPDATE piwik_version SET option_name = {old_version} WHERE option_value='core_version';

@mattab mattab self-assigned this Dec 15, 2014
@mattab
Copy link
Member Author

mattab commented Dec 15, 2014

Here is what it looks like: codebase running older than database

mattab referenced this issue Dec 15, 2014
@mattab
Fixes #6529 Throw an exception when codebase is older than schema to …
c93d3e8 
…prevent broken race conditions
@mattab mattab closed this as completed Dec 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattab mattab

Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.10.0
Development

No branches or pull requests
1 participant
@mattab