Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin for Piwik that modifies the 'API.get' output to also list the website name and main website URL. #6828

Closed
mattab opened this issue Dec 9, 2014 · 4 comments
Closed

Plugin for Piwik that modifies the 'API.get' output to also list the website name and main website URL. #6828

mattab opened this issue Dec 9, 2014 · 4 comments
Assignees
@mattab
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.10.0

Comments

@mattab
Copy link
Member

mattab commented Dec 9, 2014

To be published on the Marketplace, find it here: https://github.com/piwik/plugin-ApiGetWithSitesInfo
@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Dec 9, 2014
@mattab mattab mentioned this issue Dec 9, 2014
Closed
@mattab mattab added this to the Piwik 2.10.0 milestone Dec 9, 2014
@mattab mattab self-assigned this Dec 9, 2014
@tsteur
Copy link
Member

tsteur commented Dec 9, 2014

just one question. Wouldn't it make sense to introduce a new API method instead that merges those instead of such a hook and dataTableFilter? I don't know the requirements but if it doesn't have to be API.get it would definitely make more sense.

@mattab
Copy link
Member Author

mattab commented Dec 9, 2014

It could make sense, but I've already implemented it as decorator of
API.get... it's very specific, but it's got tests so we can change
implementation if there's a merge feature later!

@mattab
Copy link
Member Author

mattab commented Dec 9, 2014

Done! the plugin has been published on Marketplace and added to travis CI: http://plugins.piwik.org/ApiGetWithSitesInfo

@mattab mattab closed this as completed Dec 9, 2014
@tsteur
Copy link
Member

tsteur commented Dec 9, 2014

Yeah for future reference it would be better to introduce a ApiGetWithSitesInfo.get method instead of using hooks etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattab mattab

Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.10.0
Development

No branches or pull requests
2 participants
@tsteur @mattab