Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved resolution reports to a new plugin #6827

Merged
merged 13 commits into from Dec 13, 2014
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Dec 8, 2014

Next step in deprecating old UserSettings plugin is to move the resolution reports to their own plugin

refs #3962

@sgiehl sgiehl added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Dec 8, 2014
@sgiehl
Copy link
Member Author

sgiehl commented Dec 12, 2014

@mattab feel free to review / merge

@@ -109,7 +109,7 @@ public function test_checkArchiveRecords_whenPeriodIsRange()
$tests = array(
// TODO Implement fix, then remove the +3 below
'archive_blob_2010_12' => ( ($expectedActionsBlobs+3) /*Actions*/
+ 4 /* UserSettings */
+ 2 /* UserSettings */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sgiehl

'UserSettings.getResolution' is in the URL fixtures so maybe it should expect its two blobs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it should. But I guess it isn't as the method is marked as deprecated.
I'll add Resolution.getResolution instead.

@mattab
Copy link
Member

mattab commented Dec 12, 2014

let's add an upgrade script to activate the new Resolution plugin

Looks good otherwise, feel free to merge after changes!

@sgiehl sgiehl removed the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Dec 13, 2014
@sgiehl sgiehl added this to the Piwik 2.10.0 milestone Dec 13, 2014
sgiehl pushed a commit that referenced this pull request Dec 13, 2014
Moved resolution reports to a new plugin
@sgiehl sgiehl merged commit 00ea13b into master Dec 13, 2014
@sgiehl sgiehl deleted the move_resolution_report branch December 13, 2014 21:37
@mattab
Copy link
Member

mattab commented Dec 16, 2014

@sgiehl
Copy link
Member Author

sgiehl commented Dec 16, 2014

I couldn't figure out why they have no data. Might it be possible that the
omnifixture needs to be updated as I renamed the archvies?

@mattab
Copy link
Member

mattab commented Dec 17, 2014

That will be it! there is a guide at:
https://github.com/piwik/piwik/tree/master/tests#omnifixture

@sgiehl
Copy link
Member Author

sgiehl commented Dec 17, 2014

Tried that. But the command throws errors. Maybe because I'm not running piwik on localhost?

@mattab
Copy link
Member

mattab commented Dec 17, 2014

Hey Stefan, what error does it throw?

@sgiehl
Copy link
Member Author

sgiehl commented Dec 17, 2014

 [Exception]
  log importer failed: 2014-12-17 22:54:41,818: [DEBUG] Accepted hostnames: all
  2014-12-17 22:54:41,818: [DEBUG] Piwik URL is: http://localhost/./tests/PHPUnit/proxy/
  2014-12-17 22:54:41,818: [DEBUG] No token-auth specified
  2014-12-17 22:54:41,818: [DEBUG] No credentials specified, reading them from "/var/www/piwik_test/config/config.ini.php"
  2014-12-17 22:54:42,101: [DEBUG] Authentication token token_auth is: 9ad1de7f8b329ab919d854c556f860c1
  2014-12-17 22:54:42,101: [DEBUG] Resolver: static
  2014-12-17 22:54:42,107: [DEBUG] Error when connecting to Piwik: HTTP Error 404: Not Found
  2014-12-17 22:54:44,111: [DEBUG] Error when connecting to Piwik: HTTP Error 404: Not Found
  2014-12-17 22:54:46,116: [DEBUG] Error when connecting to Piwik: HTTP Error 404: Not Found
  Traceback (most recent call last):
    File "/var/www/piwik_test/misc/log-analytics/import_logs.py", line 1916, in <module>
      resolver = config.get_resolver()
    File "/var/www/piwik_test/misc/log-analytics/import_logs.py", line 765, in get_resolver
      return StaticResolver(self.options.site_id)
    File "/var/www/piwik_test/misc/log-analytics/import_logs.py", line 1106, in __init__
      'SitesManager.getSiteFromId', idSite=self.site_id
    File "/var/www/piwik_test/misc/log-analytics/import_logs.py", line 1089, in call_api
      return cls._call_wrapper(cls._call_api, None, None, method, **kwargs)
    File "/var/www/piwik_test/misc/log-analytics/import_logs.py", line 1078, in _call_wrapper
      raise Piwik.Error(message)
  __main__.Error: Not Found
  command used: python "/var/www/piwik_test/misc/log-analytics/import_logs.py" -ddd --url="http://localhost/./tests/PHPUnit/proxy/"
  --idsite="1" --enable-testmode --recorders="1" --recorder-max-payload-size="1" "/var/www/piwik_test/tests/resources/access-logs/fake_logs.log" 2>&1

Guess I would need to pass the correct server config to get it running with my current apache config.
I've changed my server config to have piwik running on localhost now and then it worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants