New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved resolution reports to a new plugin #6827
Conversation
@mattab feel free to review / merge |
@@ -109,7 +109,7 @@ public function test_checkArchiveRecords_whenPeriodIsRange() | |||
$tests = array( | |||
// TODO Implement fix, then remove the +3 below | |||
'archive_blob_2010_12' => ( ($expectedActionsBlobs+3) /*Actions*/ | |||
+ 4 /* UserSettings */ | |||
+ 2 /* UserSettings */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sgiehl
'UserSettings.getResolution' is in the URL fixtures so maybe it should expect its two blobs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it should. But I guess it isn't as the method is marked as deprecated.
I'll add Resolution.getResolution instead.
let's add an upgrade script to activate the new Looks good otherwise, feel free to merge after changes! |
Moved resolution reports to a new plugin
Hi @sgiehl ! In the UI test there is a small regression where the Resolution report are now showing no data. but it works fine on the demo2 - http://builds-artifacts.piwik.org/ui-tests.master/6407.1/screenshot-diffs/singlediff.html?processed=../processed-ui-screenshots/UIIntegrationTest_visitors_settings.png&expected=UIIntegrationTest_visitors_settings.png&github=UIIntegrationTest_visitors_settings.png |
I couldn't figure out why they have no data. Might it be possible that the |
That will be it! there is a guide at: |
Tried that. But the command throws errors. Maybe because I'm not running piwik on localhost? |
Hey Stefan, what error does it throw? |
Guess I would need to pass the correct server config to get it running with my current apache config. |
Next step in deprecating old UserSettings plugin is to move the resolution reports to their own plugin
refs #3962