Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inconsistent field names/content for visitor details in Live API (getLastVisitsDetails) #6822

Open
FelixSchwarz opened this issue Dec 7, 2014 · 2 comments
Open

inconsistent field names/content for visitor details in Live API (getLastVisitsDetails) #6822

FelixSchwarz opened this issue Dec 7, 2014 · 2 comments
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
Backlog (Help wan...

Comments

@FelixSchwarz
Copy link
Contributor

It seems inconsistent to me that visitor details in the live visitor log API ("Live.getLastVisitsDetails" ) uses "serverTimePretty" which actually contains date AND time while the attribute with the same name for actual visits only contains time (to be used with another attribute "serverDatePretty" ).

Preferrably if this is going to be fixed you could also have a look at #6814: changing the contents of "serverTimePretty" will require some code updates for all users of the API so better give them a "clean" way of consuming the information. Also the presence of the "serverTimestamp" field can be used to decide if you're talking to an older server or not.
@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Dec 7, 2014
@mattab mattab added this to the Short term milestone Dec 7, 2014
@mattab
Copy link
Member

mattab commented Dec 18, 2014

Maybe such breaking API changes this could be a good candidate for Piwik 3.0.0 ? #6074

@mattab mattab modified the milestones: Mid term, Short term Dec 18, 2014
@tsteur
Copy link
Member

tsteur commented Dec 22, 2014

👍 for fixing in Piwik 3.0.0

@mattab mattab modified the milestones: Piwik 3.0.0, Mid term Dec 22, 2014
@mattab mattab modified the milestones: Mid term, 3.0.0 Aug 13, 2015
@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
3 participants
@FelixSchwarz @tsteur @mattab