Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multisites - confusing behaviour #6807

Closed
quba opened this issue Dec 4, 2014 · 2 comments
Closed

Multisites - confusing behaviour #6807

quba opened this issue Dec 4, 2014 · 2 comments
Assignees
@tsteur
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
2.10.0

Comments

@quba
Copy link
Contributor

quba commented Dec 4, 2014

Current behaviour:

  • clicking on a column to change order, changes the data source for sparklines to the column used to order by,
  • the default value in select box above the sparklines doesn't change (this would make sense only in case the default value changes).

Currently it's really confusing.

Proposed solution:

  • do not change data source for sparklines. Change it only in case user chooses other metric from the select box.

I think it should be reproducible after fixing sparklines on demo:
http://demo.piwik.org/index.php?module=MultiSites&action=index&idSite=3&period=day&date=yesterday
@quba quba changed the title Multisite - confusing behaviour Multisites - confusing behaviour Dec 4, 2014
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Dec 7, 2014
@mattab mattab added this to the Piwik 2.10.0 milestone Dec 7, 2014
tsteur added a commit that referenced this issue Dec 9, 2014
@tsteur
refs #6807 sort sparklines depending on the column that is selected i…
c9aace8 
…n evolution column
@tsteur tsteur self-assigned this Dec 9, 2014
@tsteur
Copy link
Member

tsteur commented Dec 9, 2014

Should be fixed, please confirm and reopen in case I misunderstood something

@tsteur tsteur closed this as completed Dec 9, 2014
@quba
Copy link
Contributor Author

quba commented Dec 9, 2014

Looks good. 👍

@mattab mattab mentioned this issue Dec 12, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
2.10.0
Development

No branches or pull requests
3 participants
@tsteur @mattab @quba