Update piwik.js #6791
Closed
Update piwik.js #6791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tried implementing sendBeacon on the client side, but it seems the server side requires a different content-type? Remove "return false" from 2421 for testing. In my experience the 500ms wait is arbitrary guesswork and is not enough for slow connections from distant places. I increased this in my own implementation to 5000ms and only use it as a fallback timeout so that the navigation do not get stuck forever. Also the image.onready now requires image.onerror as well since piwik does not return a valid image anymore (return code 204)
|
please disregard from this pull request. Turns out 5000ms default expiry time is a very bad idea. I have previously been using callbacks for this but just now implemented it as a patch on the unload handler. This turns out bad as the unload handler is blocking. It will end up freezing the UI for 5s in certain situations. I will go back to the drawing board on this one. =) |
5000ms timeout is bad, even the 500ms is bad because it does a blocking wait that is only based on a guess that the request might reach in time. Because of this I stopped using "enableLinkTracking" all together and implemented trackLink with callbacks on all outlinks instead. For this to work, the callback must still be fixed, that's why I still need this patch for the "image.onerror = "
Stupid addition as the setExpireDateTime function never decreases a timeout, only extends it.
mattab
added
the
answered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried implementing sendBeacon on the client side, but it seems the server side requires a different content-type? Remove "return false" from 2421 for testing.
In my experience the 500ms wait is arbitrary guesswork and is not enough for slow connections from distant places. I increased this in my own implementation to 5000ms and only use it as a fallback timeout so that the navigation do not get stuck forever.
Also the image.onready now requires image.onerror as well since piwik does not return a valid image anymore (return code 204)
refs #6641