Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the proxy-hide-piwik-url project into a separate repository #6788

Closed
mnapoli opened this issue Dec 2, 2014 · 3 comments
Closed

Move the proxy-hide-piwik-url project into a separate repository #6788

mnapoli opened this issue Dec 2, 2014 · 3 comments
Assignees
@mnapoli
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.10.0

Comments

@mnapoli
Copy link
Contributor

mnapoli commented Dec 2, 2014

Currently we have the Piwik proxy in misc/proxy-hide-piwik-url/. When I mean "proxy", I mean How do I setup Piwik to track multiple websites without revealing the Piwik server URL?.

Since I am fixing bugs (e.g. #6712) I'm planning to extract it into a separate repository:

  • it is a project not tied to Piwik's code, so no reason to keep it in the same repository
  • it will be more visible, and easier to see the documentation (README at the index of the repo)
  • easier to track changes
  • it will be easier for users to track updates (since it's updated not really often)
  • I'll add tests & CI (already found 2 bugs)
  • I'll add a way to use it using git clone without directly editing the piwik.php file anymore (easier updates: just run git pull)

Name for the repository?

  • piwik/piwik-proxy
  • piwik/tracker-proxy
  • …
@mnapoli mnapoli added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Dec 2, 2014
@mnapoli mnapoli self-assigned this Dec 2, 2014
@mnapoli mnapoli added this to the Piwik 2.10.0 milestone Dec 2, 2014
@mnapoli
Copy link
Contributor Author

mnapoli commented Dec 3, 2014

The repository is created here: piwik/tracker-proxy

@mattab can you check the repository's permissions? When I created the repo I had to use the team "component-admin" but it's probably not the right team so it might need a change.

TODO left:

@mattab
Copy link
Member

mattab commented Dec 3, 2014

@mnapoli looks good!
the the remove step: maybe add simply README with a link to the new code so people landing there from other links will not be lost.

mnapoli added a commit that referenced this issue Dec 3, 2014
@mnapoli
#6788 Removed the tracker proxy (moved to a separate repository)
5251216
@mnapoli
Copy link
Contributor Author

mnapoli commented Dec 3, 2014

Did that, all good!

@mnapoli mnapoli closed this as completed Dec 3, 2014
mnapoli added a commit that referenced this issue Dec 7, 2014
@mnapoli
#6788 changelog
4e2205e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnapoli mnapoli

Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.10.0
Development

No branches or pull requests
2 participants
@mattab @mnapoli