Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide extended core:archive logger output messages for easier monitoring #6764

Closed
mattab opened this issue Dec 1, 2014 · 8 comments
Closed
Labels
answered For when a question was asked and we referred to forum or answered it. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.

Comments

@mattab
Copy link
Member

mattab commented Dec 1, 2014

As a Piwik developer
I'd like to have better archiving output
to make debugging easier.

What could be added:

  • log each segment archiving with time (rather than log them all at once), Log which segments are currently being archived #7536
  • ability to print API calls used to archive -> use --v to see climulti:request calls
  • during archiving - which plug-in is currently being archived, -> the plugin being archived will be logged if level is DEBUG
  • ability to easily print all queries executed during archiving, -> done in logger in verbose mode
  • Provide better information regarding memory usage by each plugin Provide better information regarding memory usage by each plugin #6708
  • while requesting from API with debug parameter - information about selected archives (idarchive, archive type, missing archives) - such debug was available in Piwik 1.*
@mattab mattab added Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. labels Dec 1, 2014
@mattab mattab added this to the Short term milestone Dec 1, 2014
@mattab mattab changed the title Provider extended core:archive logger output messages for easier monitoring Provide extended core:archive logger output messages for easier monitoring Dec 1, 2014
@diosmosis
Copy link
Member

Current status:

log each segment archiving with time (rather than log them all at once),

This is done in the #5363 pull request (#6755)

ability to print API calls used to archive (it used to work with --v option)

If debug logging level is used, the API requests will be printed out.

during archiving - which plug-in is currently being archived,

I added this a week or two ago, the plugin being archived will be logged if level is DEBUG.

ability to easily print all queries executed during archiving,

This is a duplicate of the above itme.

@mnapoli
Copy link
Contributor

mnapoli commented Dec 2, 2014

For the record I'm working on the logger refactoring and in CLI the log will be outputted according to verbosity options: i.e. it will not depend on the configuration anymore for logging to stdout (all other backends will have their logging level still configured with ini config).

So by default it will log to the console with INFO level, if you use -v (verbose) it will log with DEBUG level.

@mnapoli
Copy link
Contributor

mnapoli commented Dec 2, 2014

Monolog provides a MemoryUsageProcessor to add the memory usage in log entries, so this part could be covered by #6622.

@mattab mattab removed the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Dec 10, 2014
@mgazdzik
Copy link
Contributor

👍 for this, it would be great to have insight into which segment is currently processed (for ex. processing segment ABCD 1 of 10).
In long running archivings it's hard to determine where archiving is, which segment is heavier than other (it may give us some data to analyse segments complexity impact on processing time) and if archiving is making any progress with segments.

@quba
Copy link
Contributor

quba commented Mar 25, 2015

+1

@mattab
Copy link
Member Author

mattab commented Mar 25, 2015

good idea, see proposal in: Log which segments are currently being archived #7536

@mattab
Copy link
Member Author

mattab commented Apr 7, 2015

#7536 is last remaining sub-task. If we have any new idea to improve core:archive logger (eg. display new stats or useful info), let's create a new issue

@mattab mattab closed this as completed Apr 7, 2015
@mattab
Copy link
Member Author

mattab commented Apr 27, 2015

All done! if you have further suggestion on how to improve core:archive log output, feel free to create new issues

@mattab mattab reopened this Apr 27, 2015
@mattab mattab closed this as completed Apr 27, 2015
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

5 participants