Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed screentype report #6752

Merged
merged 7 commits into from Dec 1, 2014
Merged

Removed screentype report #6752

merged 7 commits into from Dec 1, 2014

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 29, 2014

Removed screentype report & widget.

refs #3962

@sgiehl
Copy link
Member Author

sgiehl commented Nov 29, 2014

@mattab as discussed in #3962 I've removed the screentype report in this PR. Please review and merge. Guess screenshot tests need to be adjusted afterwards

@mattab mattab added this to the Piwik 2.10.0 milestone Dec 1, 2014
@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Dec 1, 2014
@@ -77,9 +77,7 @@
<location>France</location>
<latitude />
<longitude />
<screenType>normal</screenType>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgiehl maybe note in the changelog that those fields were removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in 1a2c0ad

mattab pushed a commit that referenced this pull request Dec 1, 2014
@mattab mattab merged commit f9a1f92 into master Dec 1, 2014
@sgiehl sgiehl deleted the remove_screentype_report branch December 1, 2014 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants