Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeviceDetection upgrade in b1 timed out #6750

Closed
mattab opened this issue Nov 29, 2014 · 9 comments
Closed

DeviceDetection upgrade in b1 timed out #6750

mattab opened this issue Nov 29, 2014 · 9 comments
Assignees
Labels
answered For when a question was asked and we referred to forum or answered it. Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Nov 29, 2014

The upgrade worked on demo2 but failed on demo - it failed quickly and without errors... i cant figure out more info but somehow we'll need to make this migration more reliable. cc @sgiehl or maybe we can disable by default the report migration and let users who want do it with a console command maybe?

@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Nov 29, 2014
@mattab mattab added this to the Piwik 2.10.0 milestone Nov 29, 2014
@sgiehl
Copy link
Member

sgiehl commented Nov 29, 2014

Hm. So no error message? Might it have been some kind of timeout? I could add some try/catch around the archive creation. maybe there could occur errors if an archive is some sort of "broken".

btw. maybe we should try to find a way to have long running updates in the browser.
Most scripts should be splitable into smaller parts that could be run one after the other doing some kind of page reload in the browser to avoid timeouts.
Guess that should easily be possible for loops doing queries like in that update script. We just would need to pass the current step/item with the url on page reload to start from there then.

@mattab
Copy link
Member Author

mattab commented Dec 2, 2014

No error message 👎 I didn't investigate much further. I'm not so sure we should run the upgrade anyway, as it could be just too huge. To provide them an option I'd just create the console command rather than try execute it in the browser... I don't think people will care so much if they lose the OS/Browsers historical data (before enabling DeviceDetection).

@sgiehl
Copy link
Member

sgiehl commented Dec 2, 2014

we could rename the existing archives. which should not take too long. That would mean only archives with browser version would be available for older data. browser family reports would then be missing.

@mattab
Copy link
Member Author

mattab commented Dec 2, 2014

@sgiehl this sounds good to me! +1

@mattab mattab assigned sgiehl and unassigned mattab Dec 2, 2014
@sgiehl
Copy link
Member

sgiehl commented Dec 2, 2014

Ok. I'll have a look at that within the next few days

sgiehl added a commit that referenced this issue Dec 6, 2014
…chives without versions where they do not exist. Instead added a fallback in the api methods to build the reports on the fly if requested
@sgiehl
Copy link
Member

sgiehl commented Dec 6, 2014

@mattab Please review my changes. The archives will now only be renamed/replaced if required. Archive rebuilding won't be done anymore. Instead the API will build the reports on the fly out of the archives with versions if requested.

@sgiehl
Copy link
Member

sgiehl commented Dec 6, 2014

There's still a little bug with periods != day. I'll try to fix that tomorrow

@sgiehl
Copy link
Member

sgiehl commented Dec 7, 2014

Everything should be fixed here then. Hope the update doesn't fail this time on demo. If not guess we can close the ticket.

@mattab
Copy link
Member Author

mattab commented Dec 8, 2014

Hi Stefan! The upgrade worked on the demo and demo2 :)

@sgiehl sgiehl closed this as completed Dec 8, 2014
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Dec 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it. Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants