New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DeviceDetection upgrade in b1 timed out #6750
Comments
Hm. So no error message? Might it have been some kind of timeout? I could add some try/catch around the archive creation. maybe there could occur errors if an archive is some sort of "broken". btw. maybe we should try to find a way to have long running updates in the browser. |
No error message 👎 I didn't investigate much further. I'm not so sure we should run the upgrade anyway, as it could be just too huge. To provide them an option I'd just create the console command rather than try execute it in the browser... I don't think people will care so much if they lose the OS/Browsers historical data (before enabling DeviceDetection). |
we could rename the existing archives. which should not take too long. That would mean only archives with browser version would be available for older data. browser family reports would then be missing. |
@sgiehl this sounds good to me! +1 |
Ok. I'll have a look at that within the next few days |
…chives without versions where they do not exist. Instead added a fallback in the api methods to build the reports on the fly if requested
@mattab Please review my changes. The archives will now only be renamed/replaced if required. Archive rebuilding won't be done anymore. Instead the API will build the reports on the fly out of the archives with versions if requested. |
There's still a little bug with periods != day. I'll try to fix that tomorrow |
Everything should be fixed here then. Hope the update doesn't fail this time on demo. If not guess we can close the ticket. |
Hi Stefan! The upgrade worked on the demo and demo2 :) |
The upgrade worked on demo2 but failed on demo - it failed quickly and without errors... i cant figure out more info but somehow we'll need to make this migration more reliable. cc @sgiehl or maybe we can disable by default the report migration and let users who want do it with a console command maybe?
The text was updated successfully, but these errors were encountered: