Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tibet back to China map #6749

Closed
wants to merge 11 commits into from
Closed

Add Tibet back to China map #6749

wants to merge 11 commits into from

Conversation

huangzhong
Copy link

Remove commit 4e47c8 (Remove Tibet from the map) #6006

@mattab
Copy link
Member

mattab commented Dec 1, 2014 •
edited

Hi there, thanks for the pull request. I notice it includes other commits as well. Please feel free to apply the patch to your local instance if you want to hide Tibet from the map. this is the beauty of free software that you can automatically customise it 👍

More info: #6994 (comment)

Take care

@mattab mattab closed this Dec 1, 2014
@mattab mattab added the wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it. label Dec 1, 2014
@imlonghao imlonghao mentioned this pull request Jan 13, 2015
Closed
@khlipeng
Copy link

Tibei and Taiwan should be a part of China

@sgiehl sgiehl mentioned this pull request Jun 28, 2017
Closed
@sgiehl sgiehl mentioned this pull request Jul 5, 2017
Closed
@fengkaijia fengkaijia mentioned this pull request Aug 1, 2017
Closed
@xiasun
Copy link

xiasun commented Aug 2, 2017

I wonder when it comes to different points of view, based on which knowledge are you going to decide whether accept it or not?

For example, you accepted Tibet here as an independent country, why won't you accept California as an independent country? I want to learn about your common rule for this kind of issue.

Seriously this is important for an open source software developer.

@justjavac
Copy link

Tibei and Taiwan should be a part of China

1 similar comment
@huruji
Copy link

huruji commented Aug 2, 2017

Tibei and Taiwan should be a part of China

@jamesjieye
Copy link

@mattab This is not cool!!! You are not acting based on common knowledge.

kinosang referenced this pull request in kinosang/piwik Aug 3, 2017
@kinosang
Add Tibet Autonomous Region back to China
52403b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@huangzhong @mattab @khlipeng @xiasun @justjavac @huruji @jamesjieye