@anonymous-piwik-user opened this Issue on April 22nd 2009

I posted a blog comment about this but I think someone deleted my comment. All the api token authentication is completely busted. I had posted the fix in the comment, but now i can't find it. I don't see any mention in the changelog so I'm assuming it's not fixed.

@anonymous-piwik-user commented on April 22nd 2009

in core/API/Request.php parse_str is incorrectly used and overwrites all contents of $requestArray, thus erasing any supplied token_auth parameter. A new array should be passed to parse_str and the contents then merged into $requestArray.

                    $request = trim($request);
                    $request = str_replace(array("\n","\t"),'', $request);

$newAr = array();
parse_str($request, $newAr);
$requestArray = $requestArray + $newAr;

@anonymous-piwik-user commented on April 22nd 2009


comments on the parse_str page which verify that parse_str does erase the contents of the second parameter before putting the results into it.

@robocoder commented on April 22nd 2009 Contributor

Refactored in [1021]

@anonymous-piwik-user commented on April 22nd 2009

changeset 1021 does not change the affected code. I checked SVN before I submitted this bug, it is still present.


    function __construct($request = null)
        $defaultRequest = $_GET + $_POST;
        $requestArray = $defaultRequest;

            $request = trim($request);
            $request = str_replace(array("\n","\t"),'', $request);
            parse_str($request, $requestArray);

            // if a token_auth is specified in the API request, we load the right permissions
                Piwik_PostEvent('API.Request.authenticate', $requestArray['token_auth']);

            $requestArray = $requestArray + $defaultRequest;

parse_str($request, $requestArray) <-- $requestArray is now an empty array. Next line is

if isset($requestArray['token_auth']))

^ always false (unless token_auth is present in $request)

But, we can see that token_auth is not present in $request

plugins/VisitsSummary/Controller.php getVisits()

            $requestString =        "method=VisitsSummary.getVisits".                                                        "&format=original".                                                        "&disable_generic_filters=true";
            $request = new Piwik_API_Request($requestString);
            return $request->process();
@anonymous-piwik-user commented on April 22nd 2009

You can also test this bug by requesting any API plugin with an auth token and seeing that it does not work.

$today   = date('Y-m-d');
$startDay = date('Y-m-d', (time() - 3600*24*12));

      $dataUrl =  'http://'.$host.$path .'index.php';
      $dataUrl .= '?module=VisitsSummary';
      $dataUrl .= '&action=getLastVisitsGraph';
      $dataUrl .= '&idSite='.$siteid;
      $dataUrl .= '&period=day';
      $dataUrl .= '&date='. $startDay;
      $dataUrl .= '%2C'. $today;
      $dataUrl .= '&viewDataTable=generateDataChartEvolution';
      $dataUrl .= '&disableLink=1';
      $dataUrl .= '&token_auth='.$token;
      $data =  file_get_contents($dataUrl);

w/o patch you get a login HTML page.
w/patch you get the data.

@robocoder commented on April 22nd 2009 Contributor

Sorry, but I think you misread the code and PHP docs.

Yes, parse_str() stores its results in the second parameter (in this case, $requestArray). While it is true that we overwrite the previous contents of $requestArray where the code was earlier initialize, $requestArray is not an empty array.

Without your mods and no token, I get:

<?xml version="1.0" encoding="utf-8" ?>
    <error message="You can't access this resource as it requires a 'view' access for the website id = 1." />

If I use a valid token, I get the expected results for VisitsSummary.getVisits.

(BTW your last example is not a valid API call.)

This Issue was closed on August 4th 2009
Powered by GitHub Issue Mirror