Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let plugins extend the system check and add new diagnostics #6726

Closed
tsteur opened this issue Nov 26, 2014 · 2 comments
Closed

Let plugins extend the system check and add new diagnostics #6726

tsteur opened this issue Nov 26, 2014 · 2 comments
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. duplicate For issues that already existed in our issue tracker and were reported previously. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone

Comments

@tsteur
Copy link
Member

tsteur commented Nov 26, 2014

Useful for many things:

  1. We could run the system check for plugins before activating it. Eg plugins might want to check whether a certain PHP extension is installed etc. Some plugins might require a certain webserver or other things. While some conditions could be maybe done with require: in plugin.json many cannot.
  2. To show errors, warnings, notices, ... in the system check page under Settings => Diagnose => System Check.
  3. I had more advantages in mind but forgot them :) Basically for monitoring etc.

Use case: In Redis Queue plugin we could check for having an extension installed or not, whether a Redis server is actually present and / or whether the connection to the Redis server can be established etc.

@tsteur tsteur added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. labels Nov 26, 2014
@mattab mattab added this to the Short term milestone Dec 1, 2014
mattab added a commit that referenced this issue Dec 15, 2014
@mattab mattab modified the milestones: Short term, Mid term Apr 7, 2015
@mnapoli
Copy link
Contributor

mnapoli commented Apr 17, 2015

For the record #7646 has been merged, it covers the 2nd point.

@mattab
Copy link
Member

mattab commented May 5, 2016

"Let plugins extend the system check" was done, see existing diagnostics classes: https://github.com/piwik/piwik/search?utf8=%E2%9C%93&q=implements+Diagnostic 👍

@mattab mattab closed this as completed May 5, 2016
@mattab mattab changed the title Let plugins allow to extend the system check Let plugins extend the system check and add new diagnostics Aug 3, 2016
@mattab mattab added the duplicate For issues that already existed in our issue tracker and were reported previously. label Aug 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. duplicate For issues that already existed in our issue tracker and were reported previously. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

3 participants