New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some UI screenshot tests fail at random #6693
Comments
|
The Transitions random failure was fixed. Now we often see this error: http://builds-artifacts.piwik.org/ui-tests.master/10667.7/screenshot-diffs/singlediff.html?processed=../processed-ui-screenshots/ActionsDataTable_column_sorted.png&expected=ActionsDataTable_column_sorted.png&github=ActionsDataTable_column_sorted.png but unfortunately we still don't know how to prevent this random failure. a hard to find edge case in Javascript or css or... |
Moving to |
There is some feature in mocha to retry tests: https://www.npmjs.com/package/mocha-retry we agree with what the devs says eg. however in this case i reckon none of us know how to fix the UI tests, so maybe a retry (only for those tests that are know to randomly fail) would be a correct solution |
I asked the developer of mocha-retry for help in giggio/mocha-retry#6 If we can't make mocha-retry work maybe we could try this other tool: https://github.com/lennym/mocha-extra-shot |
Answer from the dev of mocha-retry:
So it looks like we're back to square one, maybe the only way will be to actually solve the random screenshot rendering issues... |
Here is a typical random screenshot failure: http://builds-artifacts.piwik.org/ui-tests.master/13257.7/screenshot-diffs/diffviewer.html
Maybe we could change the positioning of this element, eg. position it relative to the right column, and this could prevent the random UI failure? |
@mattab that's exactly what I was working on yesterday ;) Here is the UI diff: http://builds-artifacts.piwik.org/ui-tests.fix-ui-tests-visitor-log/13240.7/screenshot-diffs/diffviewer.html What I did is disable the float and have 2 rows of icons. I can create a pull request later. |
Here is the change for the visitor log: #8090 |
Note - in case we notice that we still have as many random build failures, we should revert this pull request: #8167 |
Moving to 2.14.1 to make an even stronger push for having Green builds, every day, for our UI screenshot tests. The team is all very much looking forward to reach this beautiful goal! |
|
Created separate issue: Screenshot test CI job is running too long #8222 |
Opt-out with safari agent, seems to be the last randomly failing UI test: http://builds-artifacts.piwik.org/ui-tests.8290/14030.7/ @diosmosis maybe you have some idea what could cause this UI test to randomly fail (it seems to work more than half of the time) |
Along with "opt-out with safari use case", one of our newly added UI test for the Maps, randomly fail quite rarely. I've seen this failure 2-3 times, last one being: http://builds-artifacts.piwik.org/ui-tests.master/14138.7/ which was around midnight UTC. I guess these two tests fail when the build runs shortly after midnight UTC. Edit: actually it's now 7AM UTC and still the build is failing https://travis-ci.org/piwik/piwik/jobs/70761848 so the issue is not only around midnight utc |
We're really not sure how to fix any remaining random UI issue, but we will keep an eye on these issues. |
It seems that all random issues are finally fixed!!! OMG Happiness is overwhelming me right now ;-) Well done for sticking with us while this was sorted out (took more than one year and dozens of little issues!) |
Oh no I was mistaken, random failures still occur.... Maybe the only way going forward will be to use electron instead of phantomjs. We will investigate over next 6 months |
In Piwik 3 we've upgraded Phantomjs to phantomjs 2 since it was required for compatibility with our heavier use of modern JavaScript (AngularJS), but we still have random screenshot fails. Now tracked in #10536 |
This issue is to keep track of some of the UI screenshot tests that randomly fail. Hopefully we can solve of some of those issues and identify best practise for future UI tests.
Note that we already had to disable a few tests because they failed randomly. They are marked with
it.skip
there are listed here: https://github.com/piwik/piwik-ui-tests/search?utf8=%E2%9C%93&q=%22it.skip%28%22&type=CodeThe text was updated successfully, but these errors were encountered: