Throw HTTP 400 error when idsite is invalid #6671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0 in case Idsite is wrong
… correct I think
…d is actually a server error not request error
| } | ||
|
|
||
| if (strpos(PHP_SAPI, '-fcgi') === false) { | ||
| $key = $_SERVER['SERVER_PROTOCOL']; |
There was a problem hiding this comment.
SERVER_PROTOCOL should be safe and it should not be possible to inject values as the server is supposed to reject any invalid value. Let me know in case we should validate it in some way, not sure about all possible values
|
Looks great! 👍 |
|
OK, going to merge. |
tsteur
added a commit
that referenced
this pull request
Nov 16, 2014
Throw HTTP 400 error when idsite is invalid
tsteur
added
Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6661 When
idsiteis set to 0 or incorrectly, Piwik Tracker requests will send a HTTP 500 error. This causes monitoring system to be triggered when in fact this is not a server error 500 but rather it is a error400 Bad Request. Also if forced idVisitor is wrong. Not sure if there are many other use cases we'll have to add them on demand