Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracker throws 500 errors when idsite is invalid causing false alerts #6661

Closed
mattab opened this issue Nov 13, 2014 · 5 comments
Closed

Tracker throws 500 errors when idsite is invalid causing false alerts #6661

mattab opened this issue Nov 13, 2014 · 5 comments
Assignees
@tsteur
Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.10.0

Comments

@mattab
Copy link
Member

mattab commented Nov 13, 2014

When idsite is set to 0 or incorrectly, Piwik Tracker requests will send a HTTP 500 error. This causes monitoring system to be triggered when in fact this is not a server error 500 but rather it is a error 400 Bad Request.

The goal of this issue is to make sure Tracker will only return 500 error when indeed it is a server or database failure.
@mattab mattab added Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. labels Nov 13, 2014
@mattab mattab added this to the Piwik 2.10.0 milestone Nov 13, 2014
@tsteur tsteur self-assigned this Nov 13, 2014
tsteur added a commit that referenced this issue Nov 13, 2014
@tsteur
refs #6661 initial work on triggering a 400 bad request instead of 50…
25aace1 
…0 in case Idsite is wrong
tsteur added a commit that referenced this issue Nov 13, 2014
@tsteur
refs #6661 in case value is empty set a default
33b4f8f
tsteur added a commit that referenced this issue Nov 13, 2014
@tsteur
refs #6661 undoing this change to hopefully avoid some merge problems
1430870
tsteur added a commit that referenced this issue Nov 14, 2014
@tsteur
refs #6661 added a test to make sure it works
d0929e8
tsteur added a commit that referenced this issue Nov 14, 2014
@tsteur
refs #6661 changed it to return an HTTP 500 code as 505 is not really…
7500b93 
… correct I think
tsteur added a commit that referenced this issue Nov 14, 2014
@tsteur
refs #6661 also return HTTP 400 when idsite is 0
03d1687
tsteur added a commit that referenced this issue Nov 14, 2014
@tsteur
refs #6661 also return a HTTP 400 in case there is another invalid re…
e66c3d5 
…quest param
tsteur added a commit that referenced this issue Nov 14, 2014
@tsteur
refs #6661 forgot to commit a file and if not suppported param is use…
332af2a 
…d is actually a server error not request error
@tsteur tsteur mentioned this issue Nov 14, 2014
Merged
@tsteur
Copy link
Member

tsteur commented Nov 14, 2014

After this is merged we should maybe document the change in CHANGELOG as this breaks previous API behavior and people might test for it (don't think so but should maybe still mention it). Haven't done it yet to avoid merge conflicts with another branch

@mattab
Copy link
Member Author

mattab commented Nov 14, 2014

+1 for changelog!

tsteur added a commit that referenced this issue Nov 16, 2014
@tsteur
refs #6661 added change of HTTP 400 tracker api to changelog
a96d880
@tsteur tsteur closed this as completed Nov 16, 2014
@7starsone
Copy link

hi, I got this in php error log:
[05-Dec-2014 19:35:52 UTC] Error in Piwik (tracker): Invalid idSite: '0'

is this related to... ?

thanks

@tsteur
Copy link
Member

tsteur commented Dec 7, 2014

This issue is already fixed. I had a quick look at the code and seems to be normal that you see this message in error log when a wrong idSite was passed to the tracker.

@7starsone
Copy link

ok, maybe normal IF I understand WHAT's the source of this "wrong" idSite.... :-D

@Seb35 Seb35 mentioned this issue Mar 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.10.0
Development

No branches or pull requests
3 participants
@tsteur @mattab @7starsone