New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Database upgrades may take too long to run in web browser #666
Comments
A command line upgrade is probably the most reasonable path given that: Going forward, users should be encouraged to stay up-to-date with releases to avoid large database updates. |
in a future version (Maciej is working on it) there will be rather big schema update (adding one field to piwik_log_link_visit_action, adding field in piwik_log_visit).. This problem will happen again. What should we do to quick fix it? A "command line" message below the normal "Welcome to Piwik! You need to update [...] If your Piwik database is large or very large and you have a shell access to your Piwik server, you can trigger the update by using the following command line: /usr/bin/php5 /path/to/piwik/index.php updateCorePlugins=1" or something similar? |
+1 |
anybody implementing this ticket should feel evil. |
Feeling evil... |
the command line tool, if this is the direction are going, could maybe read the max execution time from the config, and let the user know "Your max execution time is Xmin. If you have a medium or large Piwik installation, maybe you would like to increase this limit. Look for X in your php.ini." |
(In [1319]) refs #666 - record version of incremental updates as they are done |
When upgrading to a new version, the database upgrades take too long to run in the web browser. Mine timed out, and left me with a half upgraded database which I had to manually fix by reading the upgrade files.
I would like one or all of:
- An option to run the database upgrades at the command line.
- Progress to show which database migration is currently being run (in the web browser and/or on the command line)
- It to do each upgrade separately, and record it is done in the database. So if things go wrong, it is easier to carry on from where you left off. Only one migration would need fixing.
Example command from Updates/0.2.27.php:
ALTER TABLE `piwik_log_visit` ADD `visit_goal_converted` VARCHAR NOT NULL AFTER `visit_total`
So far that has taken 3 minutes, I suspect it will take about 6. I had a whole bunch of upgrades to run, which in total will take a couple of hours I suspect. Not a realistic thing to do in one web request.
I’ve marked this critical, as it caused my piwik installation to be totally broke during a routine upgrade.
The text was updated successfully, but these errors were encountered: