Return HTTP 204 instead of GIF for JavaScript tracking. #6659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added a new url parameter send_image=0 to disable sending an image and instead response with a 204 code
| $request = $_GET + $_POST; | ||
|
|
||
| if (array_key_exists('send_image', $request) && $request['send_image'] === '0') { | ||
| Common::sendHeader("HTTP/1.0 204 No Response"); |
There was a problem hiding this comment.
why is the 1.0 protocol used instead of 1.1 ?
tsteur
added
the
Enhancement
tsteur
added a commit
that referenced
this pull request
Nov 13, 2014
Return HTTP 204 instead of GIF for JavaScript tracking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6577 Added a new url parameter
send_image=0to disable sending an image and instead response with a 204 code. Added a couple of tests. Not sure if I forgot anything. Might be worth using this parameter in iOS & Android SDK? Shall we create issues for this?We'll have to update doc after merging it.