Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "3581 IPv6 support" #6647

Merged
merged 1 commit into from Nov 13, 2014
Merged

Revert "3581 IPv6 support" #6647

merged 1 commit into from Nov 13, 2014

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 12, 2014

Reverts #6574

See #6636

@mattab
Copy link
Member

mattab commented Nov 12, 2014

A revert button?! This is so cool !!!

@tsteur
Copy link
Member Author

tsteur commented Nov 12, 2014

I tried it with PHP 5.3 and the fatal errors as well as "Constant already defined" messages are fixed now.

Still getting those error message not sure what it is about:

FERROR UserCountry[2014-11-12 03:53:39] GeoIPAutoUpdater: Encountered PHP error when performing redundant tests on GeoIP isp database: 256: error traversing database - perhaps it is corrupt? on line 642 of /home/vagrant/www/piwik/libs/MaxMindGeoIP/geoip.inc.
ERROR UserCountry[2014-11-12 03:53:39] GeoIPAutoUpdater: Encountered PHP error when performing redundant tests on GeoIP org database: 256: error traversing database - perhaps it is corrupt? on line 642 of /home/vagrant/www/piwik/libs/MaxMindGeoIP/geoip.inc

mattab pushed a commit that referenced this pull request Nov 13, 2014
@mattab mattab merged commit 9694cee into master Nov 13, 2014
@mattab mattab mentioned this pull request Nov 13, 2014
@mattab mattab deleted the revert-6574-3581_IPv6_support branch November 13, 2014 00:15
@joostdekeijzer
Copy link

@tsteur Do you have the GeoIP PECL extension installed when you run the tests?

The travis tests also run on php5.3 and it doesn't have any fatal errors ( https://travis-ci.org/piwik/piwik/builds/40490769 )

@joostdekeijzer
Copy link

And the errors you mention are "correct". The UserCountryTest::testGeoIpUpdaterRedundantChecks() checks if broken GeoIP files are renamed. That method creates broken (empty) ISP and ORG GeoIP files.

The error you see is from the GeoIPAutoUpdater class finds a broken file. Maybe that output can be muted, I don't know...

@mattab
Copy link
Member

mattab commented Nov 14, 2014

Maybe that output can be muted

+1 I think we should be able to mute them in those tests only since we expect the warning there. feel free to remind us of this in your Pull request :)

ping @diosmosis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants