Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DataTable::EMPTY_COLUMNS_METADATA_NAME metadata #6646

Closed
diosmosis opened this issue Nov 11, 2014 · 0 comments
Closed

Remove DataTable::EMPTY_COLUMNS_METADATA_NAME metadata #6646

diosmosis opened this issue Nov 11, 2014 · 0 comments
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
Priority Backlog ...

Comments

@diosmosis
Copy link
Member

This metadata is used only by the Actions API and is only handled by getProcessedReport and Visualization.php. Handling it in "raw" API consumers makes mostly complicates the consumer code for small functionality that is only used by a handful of reports. Instead, the logic can be moved to Report metadata classes. The visualization code can be put in the Report::configureView method for reports that need to remove columns and the processed report logic can perhaps be put into a new Report::configureForApi method.
@diosmosis diosmosis added c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. labels Nov 11, 2014
@diosmosis diosmosis self-assigned this Nov 12, 2014
@mattab mattab added this to the Short term milestone Dec 1, 2014
@mattab mattab modified the milestones: Mid term, Short term Dec 19, 2014
@diosmosis diosmosis removed their assignment May 6, 2015
@mattab mattab modified the milestones: 3.0.0, Long term May 6, 2016
@mattab mattab closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2023
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
Priority Backlog (Help wanted)
Development

No branches or pull requests
3 participants
@diosmosis @mattab @sgiehl