Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier configuration to run tests #6645

Merged
merged 6 commits into from Nov 12, 2014
Merged

Easier configuration to run tests #6645

merged 6 commits into from Nov 12, 2014

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 11, 2014

see #6635

@@ -38,7 +38,7 @@ php_errors.log
/tests/lib/geoip-files/*.dat*
/tests/lib/xhprof*
/tests/PHPUnit/System/processed/
/tests/PHPUnit/phpunit.xml
tests/PHPUnit/phpunit.xml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's better to leave the leading / so that it doesn't match in sub-directories

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there actually a case where we want to commit it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't know because there are no other files like this yet we don't know what can happen in the future ;) So I'd rather view it the other way: does it make sense to ignore all files matching tests/PHPUnit/phpunit.xml? Or do we want to exclude only one specific file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind to change it but do not see a big point in this case. I was even thinking about excluding all phpunit.xml as only phpunit.xml.dist files should be in the repository from what I learnt today.

tsteur added a commit that referenced this pull request Nov 12, 2014
Easier configuration to run tests
@tsteur tsteur merged commit da98a5c into master Nov 12, 2014
@tsteur tsteur deleted the 6635 branch November 12, 2014 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants