New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Easier configuration to run tests #6645
Conversation
…ems to simplify quite a lot.
…lled then we can configure most parts for the user
…orted out of the box by phpunit
@@ -38,7 +38,7 @@ php_errors.log | |||
/tests/lib/geoip-files/*.dat* | |||
/tests/lib/xhprof* | |||
/tests/PHPUnit/System/processed/ | |||
/tests/PHPUnit/phpunit.xml | |||
tests/PHPUnit/phpunit.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's better to leave the leading /
so that it doesn't match in sub-directories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there actually a case where we want to commit it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't know because there are no other files like this yet we don't know what can happen in the future ;) So I'd rather view it the other way: does it make sense to ignore all files matching tests/PHPUnit/phpunit.xml
? Or do we want to exclude only one specific file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind to change it but do not see a big point in this case. I was even thinking about excluding all phpunit.xml
as only phpunit.xml.dist
files should be in the repository from what I learnt today.
Easier configuration to run tests
see #6635