Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geoip.inc error in 2.9.0-b8 [Cannot redeclare geoip_country_code_by_name()] #6636

Closed
CarlOrff opened this issue Nov 11, 2014 · 7 comments
Closed

geoip.inc error in 2.9.0-b8 [Cannot redeclare geoip_country_code_by_name()] #6636

CarlOrff opened this issue Nov 11, 2014 · 7 comments
Milestone
2.9.0

Comments

@CarlOrff
Copy link

After update to 2.9.0-b8 Piwik stopped tracking. In my logs the following error notice occured:

2014/11/10 17:58:31 [error] 4069#0: *127577 FastCGI sent in stderr: "PHP message: PHP Fatal error: Cannot redeclare geoip_country_code_by_name() in /var/www/vhosts/xxxxxxx/libs/MaxMindGeoIP/geoip.inc on line 1593" while reading response header from upstream

I could fix it by using an older version of geoip.inc.
@tsteur
Copy link
Member

tsteur commented Nov 11, 2014

Getting same error when trying to run the unit tests in PHP 5.3. Same for geoip_country_name_by_name, for constant GEOIP_DOMAIN_EDITION, ...

MaxMind GeoIP v1 seems to be outdated. Maybe it makes sense to work on #4487?

@mattab mattab added this to the Piwik 2.9.0 milestone Nov 12, 2014
@mattab
Copy link
Member

mattab commented Nov 12, 2014

@tsteur it's bad that the piwik is broken, then I guess we should revert the IPv6 pull request before release? or do you see a way to fix the php 5.3 behavior prior to release on Thursday?

@tsteur
Copy link
Member

tsteur commented Nov 12, 2014

Would probably revert for 2.9.0 and then try to add GeoIP v2 in next version in case this one works with PHP 5.3. I tried to patch the lib and already added like 10 !defined and !function_exists checks but would have to add way more. Even then I am not sure whether everything still works correct and once the fatals re function_exists are fixed I still get the error

Encountered PHP error when performing redundant tests on GeoIP isp database: 256: error traversing database - perhaps it is corrupt? on line 1783 of /home/vagrant/www/piwik/libs/MaxMindGeoIP/geoip.inc.

@mattab
Copy link
Member

mattab commented Nov 12, 2014

@tsteur Ok thanks for the hint. would you be able to revert those commits by any c?hance

@tsteur
Copy link
Member

tsteur commented Nov 12, 2014

I think so, there is a button for this in GitHub UI ;) Edit: Done. See PR

@tsteur tsteur mentioned this issue Nov 12, 2014
Merged
@mattab mattab mentioned this issue Nov 13, 2014
Merged
@mattab
Copy link
Member

mattab commented Nov 13, 2014

Would probably revert for 2.9.0 and then try to add GeoIP v2 in next version in case this one works with PHP 5.3.

+1 for trying geoip V2 it would be nice if this worked across all php versions! in issue #4487

@mattab
Copy link
Member

mattab commented Nov 13, 2014

revert was successful

@mattab mattab closed this as completed Nov 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.9.0
Development

No branches or pull requests
3 participants
@tsteur @mattab @CarlOrff