Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify test suite names #6634

Closed
mnapoli opened this issue Nov 11, 2014 · 4 comments
Closed

Simplify test suite names #6634

mnapoli opened this issue Nov 11, 2014 · 4 comments
Labels
answered For when a question was asked and we referred to forum or answered it. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
Long term

Comments

@mnapoli
Copy link
Contributor

mnapoli commented Nov 11, 2014

Currently we have:

  • UnitTests
  • IntegrationTests
  • SystemTests

But in ./console tests:run we give unit, integration or system as shortcuts, which is confusing when using both the console and PHPUnit.

So how about renaming them to unit, integration and system?
@mnapoli mnapoli added the c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. label Nov 11, 2014
@mnapoli mnapoli mentioned this issue Nov 11, 2014
Open
8 tasks
@mattab
Copy link
Member

mattab commented Nov 11, 2014

+1 to rename the suites as defined in #6634

@tsteur
Copy link
Member

tsteur commented Nov 13, 2014

Just FYI: We'll also have to update all the other repositories like https://github.com/piwik/piwik-tests-plugins/blob/master/.travis.yml and https://github.com/piwik/piwik-marketplace/blob/master/templates/common/travis.yml.twig . There might be many more usages. Not sure about travis yml files of plugin developers (not talking about Piwik or Piwik PRO where we might update the generated .travis.yml automatically etc). That's why I kept the testsuite CoreTests and PluginTests to stay kinda backwards compatible

@mnapoli
Copy link
Contributor Author

mnapoli commented Nov 13, 2014

@tsteur thanks for the heads up, this is much bigger than I thought, I'm removing my branch for now maybe I'll feel more adventurous later ;)

@tsteur
Copy link
Member

tsteur commented Nov 13, 2014

You can otherwise search for the terms "UnitTests", "PluginTests", "IntegrationTests", "SystemTests" and "CoreTests" like this https://github.com/search?l=&q=PluginTests+user%3APiwik+user%3APiwikPro&ref=advsearch&type=Code&utf8=%E2%9C%93

Re plugin developers we can maybe simply make a notice in the changelog. I'm not really sure how it works there anyway

@mattab mattab added this to the Short term milestone Dec 1, 2014
@mattab mattab added c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. labels Dec 1, 2014
@mattab mattab modified the milestones: Short term, Mid term Apr 7, 2015
@mattab mattab closed this as completed May 30, 2016
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
answered For when a question was asked and we referred to forum or answered it. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
Long term
Development

No branches or pull requests
3 participants
@tsteur @mattab @mnapoli