Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beforeunload is not available in packaged apps #6614

Closed
dareid opened this issue Nov 7, 2014 · 7 comments
Closed

beforeunload is not available in packaged apps #6614

dareid opened this issue Nov 7, 2014 · 7 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@dareid
Copy link

dareid commented Nov 7, 2014

Using Piwik in a packaged chrome app produces the following error when including the piwik.js:

"beforeunload is not available in packaged apps"

Please see https://gist.github.com/dareid/eaf87732c5f79e0dfef1 as an example, load this into chrome as a unpacked extension (also demonstrates #6577)

@tsteur
Copy link
Member

tsteur commented Nov 9, 2014

Can you try if it works with Chrome Apps? It maybe won't fix your issue and I don't know how much work it is to migrate but it might we worth it as packaged apps are "deprecated" anyway from what I know.

@dareid
Copy link
Author

dareid commented Nov 10, 2014

I apologise, wrong terminology. This bug was from a chrome app

@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Dec 1, 2014
@mattab mattab added this to the Short term milestone Dec 1, 2014
@mattab mattab added Bug For errors / faults / flaws / inconsistencies etc. and removed Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. labels Dec 1, 2014
@mattab
Copy link
Member

mattab commented Apr 7, 2015

@tsteur any thought about next step on this issue? I'm wondering if it's a bug that we should fix in short term or not

@tsteur
Copy link
Member

tsteur commented Apr 7, 2015

I'd say bugs in piwik.js should be fixed in short term if possible.

@dareid what is the impact of that error? Does it track at all?

It seems like it already fails when it tries to add the event listener. A solution would be to just not listen to this event inside a chrome app? Maybe an event suspend would work as an alternative.

@mattab
Copy link
Member

mattab commented Sep 11, 2015

If anyone else experiences this issue, please let us know, we need to know if it's important to fix or not :-)

@tsteur
Copy link
Member

tsteur commented Aug 21, 2016

FYI: By 2018 Google will remove Chrome Apps from Windows, Mac, ... see https://9to5google.com/2016/08/19/chrome-apps-removed-mac-windows-linux/ However, they will remain on Chrome OS

@mattab
Copy link
Member

mattab commented Jun 19, 2017

FYI: By 2018 Google will remove Chrome Apps from Windows, Mac,

Since this will be deprecated soon we assume there is nothing to do here. Closing

@mattab mattab closed this as completed Jun 19, 2017
@mattab mattab added the wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it. label Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

No branches or pull requests

3 participants